Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF: fix TransactionCoderSpec #9922

Merged
merged 1 commit into from
Jun 8, 2021
Merged

LF: fix TransactionCoderSpec #9922

merged 1 commit into from
Jun 8, 2021

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Jun 8, 2021 •
edited
Loading

This modifies a test about version encoding that should not be run
with Rollback nodes as those do no have explicit version.

CHANGELOG_BEGIN
CHANGELOG_END

This is part of #8020.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da
LF: fix TransactionCoderSpec
66e38f7 
This modifies a test about version encoding that should not be run
with Rollback nodes as those do no have explicit version.

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da added the component/daml-engine DAML-LF Engine & Interpreter label Jun 8, 2021
@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Jun 8, 2021
cocreature
cocreature approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit bd26c43 into main Jun 8, 2021
@mergify mergify bot deleted the remy-lf-14 branch June 8, 2021 12:58
azure-pipelines bot pushed a commit that referenced this pull request Jun 9, 2021
release 1.14.0-snapshot.20210608.7123.0.3cb8d5c2
b2c6d8f 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
3cb8d5c Deprecate use of divulged contracts (#9930)
e9a2e2e Allow two different time formats as input for the metrics reporting interval (#9926)
1dc8472 Fix variable name (#9927)
4037b1c Add metrics to the http json service (#9923)
bd26c43 LF: fix TransactionCoderSpec (#9922)
69ef624 Fix flaky InstrumentedSourceSpec test (#9921)
cbcec32 LF: clean up the remaining Exception TODOs (#9913)
5374209 Add dependency proto3-suite for Setup.hs (#9917)
c77324d skip fix_bazel_cache on forks (#9920)
ddf93fc Address TODOs in JdbcIndexer (#9911)
a0d3e80 Add missing telemetryContext instances in the ledger-api-client's Ctx (#9916)
1e009b4 Upgrade canton to 0.25.0-snapshot supporting lf-1.13 and enable/fix tests (#9915)
db14536 LF: Freeze archive proto for LF 1.14 (#9912)
15f9dfb update compat versions for 1.14.0-snapshot.20210602.7086.0.f36f556b (#9900)
b4247c1 [In-memory fan-out] BuffersUpdater implementation (#9858)
7e733c3 DPP-390 remove appendonly todos (#9910)
512f1fd  LF: Preview version of LF 1.14 (#9906)
2da94c3 Add warning about using divulged contracts in pruning doc (#9883)
3dee3d0 LF: Fix encoder for Exception (#9904)
b22c046 ledger-api-test-tool: Only wait for parties on participants under test. (#9903)
b8c02d6 Bump perf test for for #9871 (#9902)
4660e57 Fix typoed participant name in ExceptionsIT (#9901)
316069d Postgres batching refinements (#9898)
7bc925e LF: Factorize the logic for AST lookup (#9871)
2fa250f DPP-387 Remove migration todos (#9896)
65f9395 Try to fix windows skipping again (#9893)
850c731 Include PackageMetadata in LF interface (#9892)
41266c3 Fix the formatting on the LF spec. (#9889)
dc79830 DPP-393 Enable sandbox tests for the append-only schema (#9876)
3c83b77 Parallel Ingestion renames (#9894)
6e48034 Dpp 392 todo cleanup postgre batch (#9875)
08ed7b6 rotate release duty after 1.14.0-snapshot.20210601.7081.0.7d716e6d (#9878)
081c54b Revert "Try to unflake JSON API failure tests (#9855)" (#9887)
df0f3ff maybe fix deleted release tags (#9891)
4b020dd Release ledger-api-bench-tool (#9890)
d801914 Release new snapshot (#9885)
4a4dde0 Implemented JdbcLedgerDaoTransactionLogUpdatesSpec (#9813)
```
Changelog:
```
- [Ledger API] Use of divulged contracts in later transactions is
deprecated. Divulged contracts were already incompatible with
pruning. We are working on features to handle the cases currently
covered by divulgence.
- for applications which support the --metrics-reporter-interval cli option, these now support both the java and scala duration string format (e.g. PT1M30S and 1.5min)
Small fixes to the doc
[HTTP/JSON API]
- metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus://
- metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden)
[ledger api] Add warning about incompatibility between pruning and
divulged contracts to pruning docs.
```

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da pushed a commit that referenced this pull request Jun 9, 2021
@azure-pipelines
release 1.14.0-snapshot.20210608.7123.0.3cb8d5c2 (#9932)
fce8e54 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
3cb8d5c Deprecate use of divulged contracts (#9930)
e9a2e2e Allow two different time formats as input for the metrics reporting interval (#9926)
1dc8472 Fix variable name (#9927)
4037b1c Add metrics to the http json service (#9923)
bd26c43 LF: fix TransactionCoderSpec (#9922)
69ef624 Fix flaky InstrumentedSourceSpec test (#9921)
cbcec32 LF: clean up the remaining Exception TODOs (#9913)
5374209 Add dependency proto3-suite for Setup.hs (#9917)
c77324d skip fix_bazel_cache on forks (#9920)
ddf93fc Address TODOs in JdbcIndexer (#9911)
a0d3e80 Add missing telemetryContext instances in the ledger-api-client's Ctx (#9916)
1e009b4 Upgrade canton to 0.25.0-snapshot supporting lf-1.13 and enable/fix tests (#9915)
db14536 LF: Freeze archive proto for LF 1.14 (#9912)
15f9dfb update compat versions for 1.14.0-snapshot.20210602.7086.0.f36f556b (#9900)
b4247c1 [In-memory fan-out] BuffersUpdater implementation (#9858)
7e733c3 DPP-390 remove appendonly todos (#9910)
512f1fd  LF: Preview version of LF 1.14 (#9906)
2da94c3 Add warning about using divulged contracts in pruning doc (#9883)
3dee3d0 LF: Fix encoder for Exception (#9904)
b22c046 ledger-api-test-tool: Only wait for parties on participants under test. (#9903)
b8c02d6 Bump perf test for for #9871 (#9902)
4660e57 Fix typoed participant name in ExceptionsIT (#9901)
316069d Postgres batching refinements (#9898)
7bc925e LF: Factorize the logic for AST lookup (#9871)
2fa250f DPP-387 Remove migration todos (#9896)
65f9395 Try to fix windows skipping again (#9893)
850c731 Include PackageMetadata in LF interface (#9892)
41266c3 Fix the formatting on the LF spec. (#9889)
dc79830 DPP-393 Enable sandbox tests for the append-only schema (#9876)
3c83b77 Parallel Ingestion renames (#9894)
6e48034 Dpp 392 todo cleanup postgre batch (#9875)
08ed7b6 rotate release duty after 1.14.0-snapshot.20210601.7081.0.7d716e6d (#9878)
081c54b Revert "Try to unflake JSON API failure tests (#9855)" (#9887)
df0f3ff maybe fix deleted release tags (#9891)
4b020dd Release ledger-api-bench-tool (#9890)
d801914 Release new snapshot (#9885)
4a4dde0 Implemented JdbcLedgerDaoTransactionLogUpdatesSpec (#9813)
```
Changelog:
```
- [Ledger API] Use of divulged contracts in later transactions is
deprecated. Divulged contracts were already incompatible with
pruning. We are working on features to handle the cases currently
covered by divulgence.
- for applications which support the --metrics-reporter-interval cli option, these now support both the java and scala duration string format (e.g. PT1M30S and 1.5min)
Small fixes to the doc
[HTTP/JSON API]
- metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus://
- metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden)
[ledger api] Add warning about incompatibility between pruning and
divulged contracts to pruning docs.
```

CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@remyhaemmerle-da @cocreature