Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in DAML #8020

Closed
36 tasks done
sofiafaro-da opened this issue Nov 20, 2020 · 3 comments
Closed
36 tasks done

Exceptions in DAML #8020

sofiafaro-da opened this issue Nov 20, 2020 · 3 comments
Labels
language Language team work

Comments

@sofiafaro-da
Copy link
Contributor

sofiafaro-da commented Nov 20, 2020

Over-arching ticket for implementing exceptions in DAML ("one ring to rule them all"), so we have an issue number to keep track of work to be done. See also the exception milestone.

TODO:

@sofiafaro-da sofiafaro-da added the language Language team work label Nov 20, 2020
@sofiafaro-da sofiafaro-da added this to the DAML Exceptions milestone Nov 20, 2020
sofiafaro-da added a commit that referenced this issue Nov 30, 2020
Part of #8020. This extracts the DAML_EXCEPTIONS feature from #8023
since we need it for typechecking & LF conversion soon.

changelog_begin
changelog_end
mergify bot pushed a commit that referenced this issue Dec 1, 2020
* Add DAML_EXCEPTIONS feature.

Part of #8020. This extracts the DAML_EXCEPTIONS feature from #8023
since we need it for typechecking & LF conversion soon.

changelog_begin
changelog_end

* add full url

* add another url
sofiafaro-da added a commit that referenced this issue Dec 3, 2020
Part of #8020

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Dec 7, 2020
* Add serializability check for exceptions.

Part of #8020

changelog_begin
changelog_end

* typo
remyhaemmerle-da pushed a commit that referenced this issue Dec 16, 2020
This advances states of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
sofiafaro-da added a commit that referenced this issue Dec 16, 2020
Part of #8020. This PR changes the exception protobuf and AST (Haskell
side) to make exceptions be thrown directly via a primitive expression
(EThrow), instead of wrapping them up via AnyException.

changelog_begin
changelog_end
remyhaemmerle-da pushed a commit that referenced this issue Dec 16, 2020
This advances states of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
sofiafaro-da added a commit that referenced this issue Dec 17, 2020
Part of #8020. This PR changes the exception protobuf and AST (Haskell
side) to make exceptions be thrown directly via a primitive expression
(EThrow), instead of wrapping them up via AnyException.

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Dec 17, 2020
Part of #8020. This PR changes the exception protobuf and AST (Haskell
side) to make exceptions be thrown directly via a primitive expression
(EThrow), instead of wrapping them up via AnyException.

changelog_begin
changelog_end
remyhaemmerle-da pushed a commit that referenced this issue Dec 17, 2020
Part of #8020. This PR changes the exception protobuf and AST (Haskell
side) to make exceptions be thrown directly via a primitive expression
(EThrow), instead of wrapping them up via AnyException.

changelog_begin
changelog_end
remyhaemmerle-da pushed a commit that referenced this issue Dec 17, 2020
This advances states of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
sofiafaro-da added a commit that referenced this issue Dec 17, 2020
* Update protobuf to throw exceptions directly.

Part of #8020. This PR changes the exception protobuf and AST (Haskell
side) to make exceptions be thrown directly via a primitive expression
(EThrow), instead of wrapping them up via AnyException.

changelog_begin
changelog_end

* Rename MakeAnyException to ToAnyException

* update EToAnyException field names

* Missing stuff

* missing scala case

* Make AnyException unserializable

* reindex protobuf builtins

* meaningless change

* refrobulate

* change pretty
remyhaemmerle-da pushed a commit that referenced this issue Dec 17, 2020
This advances states of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Dec 17, 2020
This advances states of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Jan 4, 2021
This is part of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Jan 4, 2021
This is part of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Jan 4, 2021
This includes some fixes of the DAML-LF specifications.

This is part of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Jan 4, 2021
This includes some fixes of the DAML-LF specifications.

This is part of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Jan 4, 2021
This is part of #8020.

CHANGELOG_BEGIN
CHANGELOG_END
This was referenced Jun 3, 2021
@cocreature
Copy link
Contributor

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language Language team work
Projects
None yet
Development

No branches or pull requests

2 participants