LF: Fix encoder for Exception #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG_BEGIN CHANGELOG_END
cocreature
approved these changes
Jun 3, 2021
| @@ -637,6 +637,14 @@ private[daml] class EncodeV1(minor: LV.Minor) { | |||
| .setExceptionType(excTy) | |||
| .setExceptionExpr(exc) | |||
| ) | |||
| case EToAnyException(ty, body) => | |||
There was a problem hiding this comment.
Ugh, I hate the pattern match thingy.
sofiafaro-da
reviewed
Jun 3, 2021
| @@ -637,6 +637,14 @@ private[daml] class EncodeV1(minor: LV.Minor) { | |||
| .setExceptionType(excTy) | |||
| .setExceptionExpr(exc) | |||
| ) | |||
| case EToAnyException(ty, body) => | |||
| assertSince(LV.Features.exceptions, "Expr.FromAnyException") | |||
There was a problem hiding this comment.
Suggested change
| assertSince(LV.Features.exceptions, "Expr.FromAnyException") | |
| assertSince(LV.Features.exceptions, "Expr.ToAnyException") |
There was a problem hiding this comment.
Good catch!
…e/testing/EncodeV1.scala Co-authored-by: Sofia Faro <[email protected]>
azure-pipelines bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @garyverhaegen-da is in charge of this release. Commit log: ``` 3cb8d5c Deprecate use of divulged contracts (#9930) e9a2e2e Allow two different time formats as input for the metrics reporting interval (#9926) 1dc8472 Fix variable name (#9927) 4037b1c Add metrics to the http json service (#9923) bd26c43 LF: fix TransactionCoderSpec (#9922) 69ef624 Fix flaky InstrumentedSourceSpec test (#9921) cbcec32 LF: clean up the remaining Exception TODOs (#9913) 5374209 Add dependency proto3-suite for Setup.hs (#9917) c77324d skip fix_bazel_cache on forks (#9920) ddf93fc Address TODOs in JdbcIndexer (#9911) a0d3e80 Add missing telemetryContext instances in the ledger-api-client's Ctx (#9916) 1e009b4 Upgrade canton to 0.25.0-snapshot supporting lf-1.13 and enable/fix tests (#9915) db14536 LF: Freeze archive proto for LF 1.14 (#9912) 15f9dfb update compat versions for 1.14.0-snapshot.20210602.7086.0.f36f556b (#9900) b4247c1 [In-memory fan-out] BuffersUpdater implementation (#9858) 7e733c3 DPP-390 remove appendonly todos (#9910) 512f1fd LF: Preview version of LF 1.14 (#9906) 2da94c3 Add warning about using divulged contracts in pruning doc (#9883) 3dee3d0 LF: Fix encoder for Exception (#9904) b22c046 ledger-api-test-tool: Only wait for parties on participants under test. (#9903) b8c02d6 Bump perf test for for #9871 (#9902) 4660e57 Fix typoed participant name in ExceptionsIT (#9901) 316069d Postgres batching refinements (#9898) 7bc925e LF: Factorize the logic for AST lookup (#9871) 2fa250f DPP-387 Remove migration todos (#9896) 65f9395 Try to fix windows skipping again (#9893) 850c731 Include PackageMetadata in LF interface (#9892) 41266c3 Fix the formatting on the LF spec. (#9889) dc79830 DPP-393 Enable sandbox tests for the append-only schema (#9876) 3c83b77 Parallel Ingestion renames (#9894) 6e48034 Dpp 392 todo cleanup postgre batch (#9875) 08ed7b6 rotate release duty after 1.14.0-snapshot.20210601.7081.0.7d716e6d (#9878) 081c54b Revert "Try to unflake JSON API failure tests (#9855)" (#9887) df0f3ff maybe fix deleted release tags (#9891) 4b020dd Release ledger-api-bench-tool (#9890) d801914 Release new snapshot (#9885) 4a4dde0 Implemented JdbcLedgerDaoTransactionLogUpdatesSpec (#9813) ``` Changelog: ``` - [Ledger API] Use of divulged contracts in later transactions is deprecated. Divulged contracts were already incompatible with pruning. We are working on features to handle the cases currently covered by divulgence. - for applications which support the --metrics-reporter-interval cli option, these now support both the java and scala duration string format (e.g. PT1M30S and 1.5min) Small fixes to the doc [HTTP/JSON API] - metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus:// - metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden) [ledger api] Add warning about incompatibility between pruning and divulged contracts to pruning docs. ``` CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
pushed a commit
that referenced
this pull request
Jun 9, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @garyverhaegen-da is in charge of this release. Commit log: ``` 3cb8d5c Deprecate use of divulged contracts (#9930) e9a2e2e Allow two different time formats as input for the metrics reporting interval (#9926) 1dc8472 Fix variable name (#9927) 4037b1c Add metrics to the http json service (#9923) bd26c43 LF: fix TransactionCoderSpec (#9922) 69ef624 Fix flaky InstrumentedSourceSpec test (#9921) cbcec32 LF: clean up the remaining Exception TODOs (#9913) 5374209 Add dependency proto3-suite for Setup.hs (#9917) c77324d skip fix_bazel_cache on forks (#9920) ddf93fc Address TODOs in JdbcIndexer (#9911) a0d3e80 Add missing telemetryContext instances in the ledger-api-client's Ctx (#9916) 1e009b4 Upgrade canton to 0.25.0-snapshot supporting lf-1.13 and enable/fix tests (#9915) db14536 LF: Freeze archive proto for LF 1.14 (#9912) 15f9dfb update compat versions for 1.14.0-snapshot.20210602.7086.0.f36f556b (#9900) b4247c1 [In-memory fan-out] BuffersUpdater implementation (#9858) 7e733c3 DPP-390 remove appendonly todos (#9910) 512f1fd LF: Preview version of LF 1.14 (#9906) 2da94c3 Add warning about using divulged contracts in pruning doc (#9883) 3dee3d0 LF: Fix encoder for Exception (#9904) b22c046 ledger-api-test-tool: Only wait for parties on participants under test. (#9903) b8c02d6 Bump perf test for for #9871 (#9902) 4660e57 Fix typoed participant name in ExceptionsIT (#9901) 316069d Postgres batching refinements (#9898) 7bc925e LF: Factorize the logic for AST lookup (#9871) 2fa250f DPP-387 Remove migration todos (#9896) 65f9395 Try to fix windows skipping again (#9893) 850c731 Include PackageMetadata in LF interface (#9892) 41266c3 Fix the formatting on the LF spec. (#9889) dc79830 DPP-393 Enable sandbox tests for the append-only schema (#9876) 3c83b77 Parallel Ingestion renames (#9894) 6e48034 Dpp 392 todo cleanup postgre batch (#9875) 08ed7b6 rotate release duty after 1.14.0-snapshot.20210601.7081.0.7d716e6d (#9878) 081c54b Revert "Try to unflake JSON API failure tests (#9855)" (#9887) df0f3ff maybe fix deleted release tags (#9891) 4b020dd Release ledger-api-bench-tool (#9890) d801914 Release new snapshot (#9885) 4a4dde0 Implemented JdbcLedgerDaoTransactionLogUpdatesSpec (#9813) ``` Changelog: ``` - [Ledger API] Use of divulged contracts in later transactions is deprecated. Divulged contracts were already incompatible with pruning. We are working on features to handle the cases currently covered by divulgence. - for applications which support the --metrics-reporter-interval cli option, these now support both the java and scala duration string format (e.g. PT1M30S and 1.5min) Small fixes to the doc [HTTP/JSON API] - metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus:// - metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden) [ledger api] Add warning about incompatibility between pruning and divulged contracts to pruning docs. ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines DAML Build <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
(from/to)AnyExceptionpart of #8020
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.