-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failures caused by the New Year #1066
Conversation
Example failure with DikTat 0.4.0:
The error changes when I add a dummy copyright header:
|
1ef2012
to
28867b6
Compare
Use the latest major release - 1.0.1. The previous default version 0.4.0 started causing build failures because of the copyright rule. DiKTat tests started failing after the New Year. It is not entirely clear why the tests started failing, but the error behaviour changes when adding a dummy copyright header to Kotlin source files. Example header: ``` /* Copyright (c) My Company, Ltd. 2000-2022. All rights reserved. */ ``` Release notes for DiKTat 1.0.1 mention a PR that fixes the copyrights rule: https://github.com/analysis-dev/diktat/releases/tag/v1.0.1
FIRST_COMMENT_NO_SPACES rule renamed to FIRST_COMMENT_NO_BLANK_LINE in saveourtool/diktat#759. Update explicit version to 1.0.1. Remove copyright header rules because we do not want DiKTat tests to fail every New Year.
a47192f
to
9fb30cd
Compare
Compute the current year instead of using a fixed year 2021. This test started failing after the New Year.
Use the newest DiKTat version. Change expected messages. They do not look right - probably a bug in DiKTat.
Amazing, thanks so much! I tweaked changelog entries a bit and I'll merge a whole bunch of PRs in the next hour or two :) |
@nedtwigg @lutovich thank you guys! Now the current year will properly be calculated automatically |
Bump the default DiKTat version
Use the latest major release - 1.0.1. The previous default version 0.4.0 started causing build failures because of the copyright rule. DiKTat tests started failing after the New Year. It is not entirely clear why the tests started failing, but the error behavior changes when adding a dummy copyright header to Kotlin source files. Example header:
Release notes for DiKTat 1.0.1 mention a PR that fixes the copyrights rule: https://github.com/analysis-dev/diktat/releases/tag/v1.0.1
Fix DiKTat tests after a version bump
FIRST_COMMENT_NO_SPACES
rule renamed toFIRST_COMMENT_NO_BLANK_LINE
in saveourtool/diktat#759.Update explicit version to 1.0.1.
Remove copyright header rules because we do not want DiKTat tests to fail every New Year.
Fix licence header test
Compute the current year instead of using a fixed year 2021. This test started failing after the New Year.
Fix a few more DiKTat test failures
Use the newest DiKTat version. Change expected messages. They do not look right - probably a bug in DiKTat.