Bugfix. Sanitize diktat config(#737) #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Watched config files
### What's done: * Renamed an inspection * Checked yml configuration
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
============================================
- Coverage 79.75% 79.73% -0.02%
Complexity 2016 2016
============================================
Files 97 97
Lines 5074 5074
Branches 1621 1621
============================================
- Hits 4047 4046 -1
Misses 246 246
- Partials 781 782 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
requested changes
Feb 8, 2021
| @@ -77,7 +77,7 @@ enum class Warnings( | |||
| HEADER_NOT_BEFORE_PACKAGE(true, "2.2.1", "header KDoc should be placed before package and imports"), | |||
| COMMENTED_OUT_CODE(false, "2.4.2", "you should not comment out code, use VCS to save it in history and delete this block"), | |||
| WRONG_NEWLINES_AROUND_KDOC(true, "2.4.1", "there should be a blank line above the kDoc and there should not be no blank lines after kDoc"), | |||
| FIRST_COMMENT_NO_SPACES(true, "2.4.1", "there should not be any spaces before first comment"), | |||
| FIRST_COMMENT_NO_BLANK_LINE(true, "2.4.1", "there should not be any blank lines before first comment"), | |||
There was a problem hiding this comment.
What does it check once again? Is this a first comment in the file? How is this different from blank lines rule?
There was a problem hiding this comment.
It checks that first comment starts with new line. BlankLinesRule handles blank lines in blocks before/after braces. Seems like blank lines before first comment have more complicated logic.
petertrr
approved these changes
Feb 8, 2021
lutovich
added a commit
to lutovich/spotless
that referenced
this pull request
Jan 4, 2022
FIRST_COMMENT_NO_SPACES rule renamed to FIRST_COMMENT_NO_BLANK_LINE in saveourtool/diktat#759. Update explicit version to 1.0.1. Remove copyright header rules because we do not want DiKTat tests to fail every new year.
lutovich
added a commit
to lutovich/spotless
that referenced
this pull request
Jan 4, 2022
FIRST_COMMENT_NO_SPACES rule renamed to FIRST_COMMENT_NO_BLANK_LINE in saveourtool/diktat#759. Update explicit version to 1.0.1. Remove copyright header rules because we do not want DiKTat tests to fail every New Year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #737
Actions checklist