Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update should_update_year_for_license_with_address and copyright headers to welcome 2022 #1064

Closed
wants to merge 3 commits into from
Closed

Conversation

KengoTODA
Copy link
Contributor

Thanks for keeping this awesome project useful, open, and updated 👍
Hope that 2022 will be a great year for all of you.

I found a test failure in my local, which was caused by the new year, so here I will suggest updating a test case (f4d2e48) and other documents.

This PR won't affect the built binary, so I made no change for CHANGELOGs.
Thanks for checking my PR!

@nedtwigg
Copy link
Member

nedtwigg commented Jan 5, 2022

Thanks for PR! It should be that we only bump a copyright header to 2022 if that file is actually modified during the year 2022, and Spotless should do that automatically thanks to the ratchet feature. I think the problem we're seeing in CI is actually fixed by #1066.

@nedtwigg nedtwigg closed this Jan 5, 2022
@KengoTODA KengoTODA deleted the happy-new-year branch January 5, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants