Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Make program look much prettier #498

Merged
merged 8 commits into from
May 11, 2017
Merged

Make program look much prettier #498

merged 8 commits into from
May 11, 2017

Conversation

mattstratton
Copy link
Member

This commit makes Ignites occur inline (removing the reference at the bottom).

It also adds color-coding depending upon the type.

Fixes #497
Fixes #496
Fixes #435

This commit makes Ignites occur inline
(removing the reference at the bottom).

It also adds color-coding depending upon the type.
@mattstratton
Copy link
Member Author

@mattstratton
Copy link
Member Author

Mobile view:

img_4112

compared to existing mobile view:
img_4113

@bridgetkromhout
Copy link
Contributor

I really like the look of this; nice work. I suspect people will be happier if they can override the colors. Is that possible with what you've added thus far?

@mattstratton
Copy link
Member Author

It's sorta possible. I thought about adding it in this way...have an additional, optional attribute for each element where you can specify the hex value of the background color.

HOWEVER...CSS gets bad in some cases. Because you also have to say what color is the text? What color are the links? etc.

@bridgetkromhout
Copy link
Contributor

I thought about adding it in this way...have an additional, optional attribute for each element where you can specify the hex value of the background color.

Right, basically I was thinking, we start with a recommended happy-path that looks decent. If people override and it looks terri-bad, that's possible but we'll at least recommend that they don't.

@mattstratton
Copy link
Member Author

One of the things I'm toying with once we go to hugo 0.20 is that events can actually specify some stuff specifically, like colors, in their config file. Since we can create different file types in hugo 0.20, it could be something like if you set the color scheme options in your data file, it will create something like events/2017-ponyville/2017-ponyville.css which it will then embed in the <head> of your pages only.

@bridgetkromhout
Copy link
Contributor

This looks good. I suspect people will try to do their own layout inside the ignites block - anything we can anticipate and guide might be a good idea - but overall, this is excellent.

@mattstratton
Copy link
Member Author

I suspect people will be happier if they can override the colors.

I added #511 to add this feature. I think we can deploy this without the feature and add it later, although I might try to get it in now.

# Conflicts:
#	static/css/site.css
#	static/css/site.css.map
This gives the ability to set a background color to
a program element.

Fixes #511
@mattstratton
Copy link
Member Author

Commit 9133ded adds the ability for color overrides.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants