-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This commit makes Ignites occur inline (removing the reference at the bottom). It also adds color-coding depending upon the type.
I really like the look of this; nice work. I suspect people will be happier if they can override the colors. Is that possible with what you've added thus far? |
It's sorta possible. I thought about adding it in this way...have an additional, optional attribute for each element where you can specify the hex value of the background color. HOWEVER...CSS gets bad in some cases. Because you also have to say what color is the text? What color are the links? etc. |
Right, basically I was thinking, we start with a recommended happy-path that looks decent. If people override and it looks terri-bad, that's possible but we'll at least recommend that they don't. |
One of the things I'm toying with once we go to hugo 0.20 is that events can actually specify some stuff specifically, like colors, in their config file. Since we can create different file types in hugo 0.20, it could be something like if you set the color scheme options in your data file, it will create something like |
This looks good. I suspect people will try to do their own layout inside the ignites block - anything we can anticipate and guide might be a good idea - but overall, this is excellent. |
I added #511 to add this feature. I think we can deploy this without the feature and add it later, although I might try to get it in now. |
# Conflicts: # static/css/site.css # static/css/site.css.map
This gives the ability to set a background color to a program element. Fixes #511
Commit 9133ded adds the ability for color overrides. |
This commit makes Ignites occur inline (removing the reference at the bottom).
It also adds color-coding depending upon the type.
Fixes #497
Fixes #496
Fixes #435