Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ace-editor #1217

Closed
StianJul opened this issue Feb 7, 2022 · 3 comments
Closed

Replace ace-editor #1217

StianJul opened this issue Feb 7, 2022 · 3 comments
Assignees
Milestone

Comments

@StianJul
Copy link
Collaborator

StianJul commented Feb 7, 2022

Replace the ace-editor with a new editor based on standard usage a textarea with markdown support. For example, the GitHub issue-editor seem to solve this pretty well.

Due to multiple issues that have come up, both in Devilry and the ace-editor GitHub-repo (ajaxorg/ace#2164), regarding accessibility issues and improvements, this seems to be way forward instead of trying to make the ace-editor accessibility-friendly.

Features to look into with a new text-editor:

  • Auto-growing textarea
  • "Flip" editor to a confirm-box before submitting.
  • Handle notifying users about existing "editor content", such as written text and uploaded files, if they try to navigate a way.
  • Better support for LaTeX and code snippets.
@torgeirl
Copy link
Collaborator

torgeirl commented Feb 8, 2022

@StianJul: In addition to the above mentioned, better support for LaTeX and code snippets are highly requested features.

@StianJul
Copy link
Collaborator Author

StianJul commented Feb 28, 2022

We did not have time to implement better support for LaTeX and code snippets. #1220 has been created for this and added to milestone 5.5

@StianJul
Copy link
Collaborator Author

This update must be seen together with the WCAG-improvements to file-uploader. The fileupload-improvements disables posting until the files are uploaded.

This is the closest we can come to preventing the user from submitting a "delivery" without adding extra steps for submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants