Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it impossible to get unsuccessful/incomplete deliveries #427

Closed
espenak opened this issue Jun 5, 2013 · 4 comments
Closed

Make it impossible to get unsuccessful/incomplete deliveries #427

espenak opened this issue Jun 5, 2013 · 4 comments

Comments

@espenak
Copy link
Member

espenak commented Jun 5, 2013

Today, students have to first upload their files, and then click Submit delivery. Some students (a very low percent, but it happens), forget to click submit delivery. We should be able to avoid this.

Solution

We assume that students actually want to add any delivery that they have added, so the default should be to mark the delivery as successful. However, we want students to be able to add multiple files, so we can not mark it as successful (which also implies completed) at once. We can solve this as follows:

  • We change the successful-attribute to a timestamp named publish_timestamp.

  • Each time a student adds a file on a delivery, publish_timestamp is set a couple of minutes in the future.

  • After at least one file has been uploaded, the UI shows the student a message with something like this text:

    Your delivery will be submitted automatically in
    [X] minutes and  [Y] seconds unless you add more
    files, or choose to abort the delivery. Click
    *Submit delivery* to submit at once.
    
  • The UI must, of course, also show the implied big red Abort delivery and big green Submit delivery buttons.

  • All examiner and admin APIs must be updated to filter on now > published_timestamp instead of successful==True

@espenak
Copy link
Member Author

espenak commented Jun 5, 2013

Here is a mockup of how this could look in the UI:
add delivery mockup 2

@espenak
Copy link
Member Author

espenak commented Jun 5, 2013

Note that both the deadline and the autosubmit time should be a countdown, not static text.

@tworide
Copy link
Member

tworide commented Jun 5, 2013

Default timestamp should then be now() + counter()

espenak added a commit that referenced this issue Dec 6, 2013
Also updated is_empty() and copy() to use query_successful_deliveries()
instead of deliveries. This prepares us for a solution like the one in #427.
@torgeirl
Copy link
Collaborator

Solved in #1210 / #1217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants