Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback feed form lacks label #1211

Closed
torgeirl opened this issue Jan 13, 2022 · 4 comments
Closed

Feedback feed form lacks label #1211

torgeirl opened this issue Jan 13, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@torgeirl
Copy link
Collaborator

WCAG 2.1 Success Criterion 4.1.1 requires content implemented using markup languages, elements have complete start and end tags, elements are nested according to their specifications, elements do not contain duplicate attributes, and any IDs are unique, except where the specifications allow these features.

The <form> element in the feedback feed lacks a label, making it hard to understand when navigating using assistance tools.

@torgeirl torgeirl added the wcag label Jan 13, 2022
@torgeirl torgeirl added this to the Devilry 5.4 milestone Jan 13, 2022
@StianJul StianJul assigned StianJul and unassigned StianJul Jan 28, 2022
@StianJul StianJul self-assigned this Feb 7, 2022
@StianJul
Copy link
Collaborator

StianJul commented Feb 7, 2022

@torgeirl, we've looked into the issue and have done some digging regarding a label for the textarea. It is kind of possible to achieve, but it will not make the ace-editor anymore useful for screenreaders in most cases. It seems that going down this road will only result in a, at best, subpar solution.

ajaxorg/ace#2164

We should instead implement a new text-editor based on a standard textarea to make it more accessibility-friendly, such as the editor used by GitHub.

@torgeirl
Copy link
Collaborator Author

torgeirl commented Feb 7, 2022

We should instead implement a new text-editor based on a standard textarea to make it more accessibility-friendly, such as the editor used by GitHub.

@StianJul: that sounds like a much better solution, and should also be a step towards solving some of the other issues with the editor (#917, #975, #994, #1040, #1174).

@StianJul
Copy link
Collaborator

StianJul commented Feb 7, 2022

Will be solved with #1217

@StianJul StianJul closed this as completed Feb 7, 2022
@torgeirl
Copy link
Collaborator Author

torgeirl commented Mar 4, 2022

Will be solved with #1217

Same as #1210, I assume this therefore is solved as part of #1214?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants