Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs-nextjs stack #347

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

RomanNikitenko
Copy link
Contributor

What does this PR do?:

Updates nodejs-nextjs stack:

  • Add new version: 1.2.1
  • Set schemaVersion: 2.2.2
  • Set https protocol for the endpoint
  • Set 1.2.1 version as a default one
image

Which issue(s) this PR fixes:

eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

You can use the following link to start a workspace for testing:
https://workspaces.openshift.com/#https://raw.githubusercontent.com/RomanNikitenko/registry/update-nextjs/stacks/nodejs-nextjs/1.2.1/devfile.yaml

Signed-off-by: Roman Nikitenko [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

@RomanNikitenko RomanNikitenko requested a review from a team as a code owner March 27, 2024 13:33
@openshift-ci openshift-ci bot requested review from kadel and maysunfaisal March 27, 2024 13:33
Copy link

openshift-ci bot commented Mar 27, 2024

Hi @RomanNikitenko. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jdubrick
Copy link
Contributor

/retest

@michael-valdron
Copy link
Member

@Jdubrick we'll need to rebase to your changes

FYI @RomanNikitenko

@RomanNikitenko RomanNikitenko force-pushed the update-nextjs branch 2 times, most recently from 6b17f37 to 1036d96 Compare March 28, 2024 17:29
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the reason of the PR checks are failing is devfile/api#1494

Not sure if we would like to remove completely version 1.2.0 (remove the dir and its record in the stack.yaml) like we did in #342

cc @michael-valdron @Jdubrick

@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

@RomanNikitenko could you try to rebase with the latest main. That should fix the ci failure for odo3 check

Signed-off-by: Roman Nikitenko <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@michael-valdron
Copy link
Member

Not sure if we would like to remove completely version 1.2.0 (remove the dir and its record in the stack.yaml) like we did in #342

@thepetk Prefer we don't completely remove stack versions but rather deprecate them.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm @michael-valdron sgtm to keep the 1.2.0 as is and deprecate it soon. Tested locally and is ok.

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 4, 2024
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanNikitenko, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Apr 5, 2024

could someone merge
I don't have merge permissions...

thanks in advance!

@thepetk thepetk merged commit ce31983 into devfile:main Apr 5, 2024
10 checks passed
@RomanNikitenko RomanNikitenko deleted the update-nextjs branch April 5, 2024 10:16
thepetk pushed a commit to thepetk/registry that referenced this pull request Apr 22, 2024
Signed-off-by: Roman Nikitenko <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: thepetk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants