-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs-nextjs stack #347
Conversation
Hi @RomanNikitenko. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@Jdubrick we'll need to rebase to your changes FYI @RomanNikitenko |
6b17f37
to
1036d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the reason of the PR checks are failing is devfile/api#1494
Not sure if we would like to remove completely version 1.2.0
(remove the dir and its record in the stack.yaml
) like we did in #342
@RomanNikitenko could you try to rebase with the latest main. That should fix the ci failure for odo3 check |
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
1036d96
to
c466682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm @michael-valdron sgtm to keep the 1.2.0
as is and deprecate it soon. Tested locally and is ok.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RomanNikitenko, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
could someone merge thanks in advance! |
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED Signed-off-by: thepetk <[email protected]>
What does this PR do?:
Updates
nodejs-nextjs
stack:1.2.1
schemaVersion: 2.2.2
https
protocol for the endpoint1.2.1
version as a default oneWhich issue(s) this PR fixes:
eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
You can use the following link to start a workspace for testing:
https://workspaces.openshift.com/#https://raw.githubusercontent.com/RomanNikitenko/registry/update-nextjs/stacks/nodejs-nextjs/1.2.1/devfile.yaml
Signed-off-by: Roman Nikitenko [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED