-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default version for java-wildfly-bootable-jar stack; set https protocol #345
Conversation
Hi @olexii4. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest bumping up to 1.3.0
instead of 1.2.1
because the schemaVersion
goes from 2.1.0
to 2.2.2
.
@ehsavoie as you are the owner of the stack could you please review the PR?
Another comment is if we would like to remove the version 1.2.0
completely (dir and stack.yaml record) like we did for #342
/ok-to-test |
@thepetk I have fixed the version. |
I think in this case we leave Also @olexii4 you will need to sign your latest commit for DCO check to pass :) |
Yeah I agree, that's why I had the doubt on this - cause the two versions have different schema versions. +1 on keeping the old version. |
…t https protocol Signed-off-by: Oleksii Orel <[email protected]>
I have fixed it. |
/hold as we need the approval from the owner to merge the pr |
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehsavoie, Jdubrick, olexii4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What does this PR do?:
Updates java-wildfly-bootable-jar stack:
Add new version 1.3.0
Which issue(s) this PR fixes:
eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: