Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new devfile version with an https endpoint #342

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Add a new devfile version with an https endpoint #342

merged 3 commits into from
Apr 2, 2024

Conversation

vinokurig
Copy link
Contributor

What does this PR do?:

Add an https endpoint to be able to run the application on Eclipse CHE

Which issue(s) this PR fixes:

eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@vinokurig vinokurig requested a review from a team as a code owner March 25, 2024 10:46
@openshift-ci openshift-ci bot requested review from rohitkrai03 and thepetk March 25, 2024 10:46
Copy link

openshift-ci bot commented Mar 25, 2024

Hi @vinokurig. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our updates for #312 & #298 I'm not sure if we should add an extra version or update the latest to be 2.2.1.

More detailed for this case, I'm not sure if we should follow the proposed solution or update the 2.2.0 to be 2.2.1 (dir names, version numbers and the stack.yaml).

cc @michael-valdron @Jdubrick

@Jdubrick
Copy link
Contributor

Following our updates for #312 & #298 I'm not sure if we should add an extra version or update the latest to be 2.2.1.

More detailed for this case, I'm not sure if we should follow the proposed solution or update the 2.2.0 to be 2.2.1 (dir names, version numbers and the stack.yaml).

cc @michael-valdron @Jdubrick

Based on the prior chores to update .net to https I think my vote is that we should update 2.2.0 to use https instead of a creating a new version to maintain consistency in our changes, especially if that is all that is being changed.

@vinokurig
Copy link
Contributor Author

@thepetk @Jdubrick I reverted the latest commit and made the change to the existed 2.2.0 version

@thepetk
Copy link
Contributor

thepetk commented Mar 26, 2024

@thepetk @Jdubrick I reverted the latest commit and made the change to the existed 2.2.0 version

@vinokurig apologies our discussion here might be misleading. I think it would be nice to patch the 2.2.0 version after the fix you've added. I think the best way to go is:

  • Move the 2.2.0 version dir to 2.2.1 version dir.
  • Replace the 2.2.0 with the 2.2.1 version in the stack.yaml
  • Inside the devfile.yaml of the 2.2.1 version update the metadata.version field to be 2.2.1.

This way we only have the 2.2.1 version visible.

@vinokurig
Copy link
Contributor Author

@thepetk

@vinokurig apologies our discussion here might be misleading. I think it would be nice to patch the 2.2.0 version after the >fix you've added. I think the best way to go is:

Move the 2.2.0 version dir to 2.2.1 version dir.
Replace the 2.2.0 with the 2.2.1 version in the stack.yaml
Inside the devfile.yaml of the 2.2.1 version update the metadata.version field to be 2.2.1.
This way we only have the 2.2.1 version visible.

Done, please take a look.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig I've only added a minor suggestion

stacks/nodejs-react/stack.yaml Outdated Show resolved Hide resolved
@vinokurig
Copy link
Contributor Author

@thepetk Looks like all comments are addressed, could you please take a look?

@thepetk
Copy link
Contributor

thepetk commented Apr 1, 2024

@thepetk Looks like all comments are addressed, could you please take a look?

@vinokurig I think only the DCO check needs to be fixed. Overall looks good to me.

/ok-to-test

@thepetk
Copy link
Contributor

thepetk commented Apr 1, 2024

@thepetk Looks like all comments are addressed, could you please take a look?

@vinokurig I think only the DCO check needs to be fixed. Overall looks good to me.

/ok-to-test

@vinokurig minor suggestion is to remove the 2.2.0 version directory as it is no longer listed in the stack.yaml file

@vinokurig
Copy link
Contributor Author

@thepetk

@vinokurig minor suggestion is to remove the 2.2.0 version directory as it is no longer listed in the stack.yaml file

Done.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 1, 2024
Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thepetk, vinokurig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig
Copy link
Contributor Author

vinokurig commented Apr 2, 2024

@thepetk I don't have merge permissions, could you merge please?

@thepetk thepetk merged commit 1abeae3 into devfile:main Apr 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants