Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Step 1 - Move css variables from web-components/global to css library #2236

Closed
3 tasks
micahchiang opened this issue Oct 31, 2023 · 3 comments · Fixed by department-of-veterans-affairs/component-library#945
Assignees
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

Related to #2190

As mentioned in the ticket linked to above, there are a couple different places where css variables are being declared. In an effort to make Design Tokens originating in Figma our source of truth for how css variables are generated, we need to consolidate our existing css variable usage into CSS Library.

Considerations

Tasks

  • Import css variables from css-library instead of web-components/src/global
  • Remove web-components/src/global/_variables.scss

Acceptance Criteria

  • above tasks have been completed
@caw310
Copy link
Contributor

caw310 commented Nov 1, 2023

@jamigibbs
Copy link
Contributor

During the discovery of exporting tokens into different formats, the CSS Library was imported like this to the component-library:

256351655-8201c3ea-0c73-4a33-920c-1adeaafd7e32

@it-harrison
Copy link
Contributor

@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
4 participants