Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review token implementaions #2190

Closed
4 tasks
ataker opened this issue Oct 10, 2023 · 2 comments
Closed
4 tasks

Review token implementaions #2190

ataker opened this issue Oct 10, 2023 · 2 comments
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@ataker
Copy link
Contributor

ataker commented Oct 10, 2023

Description

Per feedback on minimal header implementation:

Right now we have a tokens file in the web-components directory, in the CSS Library, and in Formation. Now we are adding random tokens here in a specific component.

It just feels like there are tokens everywhere and adding more here might make dealing with them later more challenging than it already will be.

Tasks

  • We need to review how we are managing our tokens and if we need to reorganize them.
  • Decide if we are allowed to add tokens for individual components.
  • It sounds like we'll be adding more USWDS tokens to our variables file, when will that happen and can some of these decisions wait until then?
  • Do we need a breakpoint tokens file for screen widths?

Acceptance Criteria

  • [ ]
@humancompanion-usds
Copy link
Collaborator

@micahchiang - Let's get the team on the same page here. I really don't want wanting us already creating tech debt for ourselves to have to clean-up later. We should define the process and then get into a habit of pulling the crank on adding a new token, having that show up in CSS, and being able to access it in a component CSS file (or wherever we need it).

@micahchiang
Copy link
Contributor

I created a follow up ticket to address the work needed here - #2236

TLDR: we are consolidating css variables into css library.

Will close this for now, since the tasks were for meeting and discussing a way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

3 participants