update web-components to use variables from css-library #945
Conversation
packages/web-components/package.json
Outdated
| @@ -27,6 +27,7 @@ | |||
| "serve": "stencil build --dev --watch --serve" | |||
| }, | |||
| "dependencies": { | |||
| "@department-of-veterans-affairs/css-library": "workspace:^", | |||
There was a problem hiding this comment.
update the version here to be "1.0.0" when css-library published
it-harrison
changed the title
There was a problem hiding this comment.
@it-harrison - Thanks for working on this! Could you provide a little more context for how these changes were tested? Could you please also attach some screenshots to indicate visual parity was maintained when changing the variable import? Thank you!
There was a problem hiding this comment.
@it-harrison Is it possible to clean up any lone-variables hanging around individual components like this now?
@micahchiang ticket has been updated to show process
@micahchiang ticket has been updated with testing information / screenshots |
|
@it-harrison I just wanted to make sure you saw my comment above. Is there a path forward yet for dealing with any existing variables in individual components? #945 (review) |
@jamigibbs we could move these variables into the css-library package? I'm not sure how else to leverage the fact that we are now installing css-library as a dependency. |
That's probably the best approach. Can you write up a ticket for us to follow-up on doing that? |
Chromatic
https://2236-remove-variables-file--60f9b557105290003b387cd5.chromatic.com
Description
This PR makes changes to allow for the removal of the variables.scss file from the web-component package, which is a duplicate of this file in css-library.
A companion PR for the css-library package must be merged and published before this PR is merged.
Closes 2236
Testing done
local testing done by using verdaccio to publish css-library and then consume in web-components:
css-library:
verdaccio:
web-components - build:
screenshots of some components that use variables from css-library
va-statement-of-truthva-accordionva-button<va-segmented-progress-barScreenshots
Acceptance criteria
Definition of done