CSS Library: update package.json for publishing #946
Conversation
|
Do we want this added to the component library release notes? If not then this PR should be tagged as |
|
@it-harrison I saw this was merged but I'm still not clear if we want this PR to be a part of the release notes for the component-library #946 (comment) I know that we intend for this package to have its own independent release notes but that has not been set up yet. Won't labeling this PR as |
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/css-library", | |||
| "private": true, | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Would it be an issue to start at this version number because version 0.1.0 already exists and if/when we ever make a minor version update to the package, we will not be able to publish it as 0.1.0.
https://www.npmjs.com/package/@department-of-veterans-affairs/css-library?activeTab=versions
cc @micahchiang
There was a problem hiding this comment.
hmm that's a good point. Tbh, I was the one that told @it-harrison it'd probably be okay to start at 0.0.1, so that's my bad. I think given the life cycle stage css library is in, it's probably not too big of a deal to eventually just skip over 0.1.0, unless folks feel strongly about that.
There was a problem hiding this comment.
No big deal. Someone might just be a little confused for minute. If we're following Semantic Versioning, the most important release will be 1.0.0 anyway which should signal it's ready for the public.
-
(0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
-
Version 1.0.0 defines the public API.
jamigibbs
changed the title
jamigibbs
added
minor
Chromatic
https://make-css-library-publishable--60f9b557105290003b387cd5.chromatic.com
Description
This PR makes the css-library package able to be published to npm so that it can be used as a dependency in the web-component package. There is a companion PR here, which updates web-components to use css-library to import the variables that are generated in css-library (and therefore ends the need to copy the file manually to web-components).
Testing done
local testing
Screenshots
Acceptance criteria
Definition of done