VACMS 17632 no card on non-clinical service locations #2024
Conversation
…17632-Non-Clinical-Services-No-Card
va-vfs-bot
temporarily deployed
to
master/main/VACMS-17632-Non-Clinical-Services-No-Card
There was a problem hiding this comment.
@eselkin I looked at this on the SL Tugboat and there is a lot of whitespace, can we remove all of this:
Then on the other page, referenced in the PR description, it would be better if you removed the custom 0 margin from the H5, this will allow the standard DS spacing to be used:
On the Billing and Insurance pages also, we would want to remove the custom 0 margin on the h4, for the same reason - to allow the standard DS spacing to be used:
|
@laflannery @thejordanwood wanted 45px space at the top. There was no 45px so we went with 48px. I guess the space was for some specific reason. |
|
The spacing on the divs rather than the h4 and 5 was because there were possibly absent headers before. I think. I can remove. |
|
@eselkin for our awareness and and future reference, I made a note in the ticket as to why I made my above comment and requested updates and what guidance and files I was following. |
src/site/facilities/vha_facility_nonclinical_service.drupal.liquid
Outdated
Show resolved
Hide resolved
|
To follow up. @laflannery is correct that we should not be adding custom margins here. This should use the standard Design System header margins. The speculative design file I linked to was only supposed to indicate the lack of cards/borders, not in any other way be guidance for this implementation. My apologies for muddying the waters. The principle we are following for the VBA/VAMC launch is only changing what is absolutely necessary( & a couple carefully targeted enhancements). |
|
Spacing is updated on SL tugboat @laflannery and @davidmpickett |
|
Looks great! |
|
Looks good! And in even better news, after double checking all instances from the mural, I confirmed that this resolved all the remaining funny spacing from the Conditional Location header ticket. |
eselkin
merged commit 57cb55f
into
VACMS-16144-VAMC-ServiceLocationParagraphs
* Move to Service Location Paragraphs in VAMC * merging of service_locations paragraphs * Service Hours * remove old service_location paragraphs * remove consolelog * typo on include * conditions when to show Appointments * show appointments simplification * test not possible on paragraph * testing * naming * spacing * indent * non-clinical * clena up spacing * spacing class * improving spacing slowly * spacing again * working spacing * more spacing * correct order of phone numbers and h5 for appointment related phone numbers * order * borders were not showing * bordered * accidental vet center accordion border * fix headers * VA-15959: Update VBA Service Location query for int branch (#1936) * fix for empty extensions * v3 components added, built, updated * remove extra vetcenter attributes to liquid * fix testing on phone numbers now that using va-telephone component * add more testing * make use of regexes better * explanation of matches * allow for short codes * additional info uswds * spacing on Appointments header * remove Vet Center tests from this branch * remove Vet Center tests from this branch * replace should have 2 args * remove debugging * remove extra div and strongs * optional * VACMS-17513: Remove unspecified referrals from front-end (#1982) * shows main phone or appt phone numbers and shows main phone or contact phone numbers (#1993) * Appointments top section visible when walkins unspecified and not remove_text (#2009) * Appointments top section visible when walkins unspecified * spacing * simplify conditions -- no change in logic * fix? works locally- did not push last time because of new package.json * update to variables * not elsif (#2002) * VACMS 17632 no card on non-clinical service locations (#2024) * no card on non-clinical service locations * remove comment * updated spacing * VACMS 17844 update service options values for office visits and virtual support (#2035) * working values for updated office visits and virtual * update comment * VA-17710: Change Online Schedule link for VBA Services (#2026) * memBefore memAfter * trying graceful fs * fix from VACMS-18069-EMFILE-error-memoryUsage * VA-17598: Manage Benefits online link update (#2057) * VA-17598: Add missing benefits paragraph (#2078) * hasAddress default to false --------- Co-authored-by: Max Antonucci <[email protected]> Co-authored-by: Max Antonucci <[email protected]>
On Service Location branch - will not pass CI
Summary
Related issue(s)
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
Old - Bordered - desktop
Old - Bordered - mobile
New - No border/x-padding - desktop
New - Non-bordered - mobile
Unaffected clinical service
Unaffected VBA service location
What areas of the site does it impact?
VAMC non-clinical pages
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Review on Service Location branch (do a content release with this PR)
e.g. https://web-xptmfsnjoodldn85nzgkrgljqtfbz24b.ci.cms.va.gov/northeast-ohio-health-care/medical-records-office/#get-your-records-in-person
Make sure to do a full refresh of the page if you've ever visited the page before