Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VA-17710] Update VBA "Schedule An Appointment Online" link #2026

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[VA-17710] Update VBA "Schedule An Appointment Online" link #2026

merged 1 commit into from
Apr 29, 2024

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Apr 19, 2024 •
edited
Loading

Summary

The VBA "Schedule an Appointment Online" link goes to the VAMC scheduling link. This fixes it by pointing it to VERA.

Related issue(s)

Testing done

Local, see below screenshot

Screenshots

Screen Shot 2024-04-19 at 7 37 09 PM

What areas of the site does it impact?

VBA Services

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@maxx1128 maxx1128 marked this pull request as ready for review April 20, 2024 00:25
@maxx1128 maxx1128 requested a review from a team as a code owner April 20, 2024 00:25
@eselkin
Copy link
Contributor

eselkin commented Apr 23, 2024 •
edited
Loading

So, in the Service Locations branch we no longer use the VBA service location liquid. Instead it uses the Service Location paragraph type that has the online scheduling link in there. That's where we should be updating I think.

@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch from 39c5184 to c08fbd2 Compare April 23, 2024 17:44
@maxx1128 maxx1128 requested review from a team as code owners April 23, 2024 17:44
@maxx1128 maxx1128 changed the base branch from main to VACMS-16144-VAMC-ServiceLocationParagraphs April 23, 2024 17:44
@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch from c08fbd2 to 44b7064 Compare April 23, 2024 17:46
@maxx1128
Copy link
Contributor Author

@eselkin I updated the base branch to the service location paragraphs and made the change to the paragraph type instead 👍

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-17710-vba-schedule-appt-link April 23, 2024 18:14 Inactive
@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024 •
edited
Loading

@maxx1128 This needs to be conditioned on whether the service location is for VAMC or VBA. So a parameter needs to be added around that online scheduling link if typeOfLocation is VBA or not. Then if it is, display the updated link if not display the original.

@maxx1128 maxx1128 changed the base branch from VACMS-16144-VAMC-ServiceLocationParagraphs to VACMS-17632-Non-Clinical-Services-No-Card April 24, 2024 17:21
@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch 3 times, most recently from e2d87d1 to 37d7d10 Compare April 24, 2024 17:28
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-17710-vba-schedule-appt-link April 24, 2024 17:55 Inactive
@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024

@maxx1128 Sorry about the confusion on this one. It's looking good. I think the VBA service location includes need to add typeOfLocation = "vba" and it's perfect.

@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch from 37d7d10 to 2c15877 Compare April 25, 2024 20:18
@maxx1128
Copy link
Contributor Author

@eselkin Added the extra conditional 👍

@eselkin
Copy link
Contributor

eselkin commented Apr 25, 2024

I think src/site/includes/vba_facilities/services.liquid includes on lines 94 and 105 need:
typeOfLocation = "vba"

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-17710-vba-schedule-appt-link April 25, 2024 21:25 Inactive
Base automatically changed from VACMS-17632-Non-Clinical-Services-No-Card to VACMS-16144-VAMC-ServiceLocationParagraphs April 25, 2024 22:14
@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch 2 times, most recently from 4d4b245 to 88affbe Compare April 26, 2024 02:17
@maxx1128 maxx1128 force-pushed the va-17710-vba-schedule-appt-link branch from 88affbe to c657ad7 Compare April 26, 2024 02:19
@maxx1128
Copy link
Contributor Author

@eselkin @jilladams Made both changes 👍

@eselkin eselkin self-requested a review April 26, 2024 15:16
eselkin
eselkin approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So I guess I had added that serviceLocationType variable before we used it for anything and didn't realize it was there when I created that other typeOfLocation variable. Sorry. Thanks for updating it.

@maxx1128 maxx1128 merged commit 9fdf94e into VACMS-16144-VAMC-ServiceLocationParagraphs Apr 29, 2024
16 of 19 checks passed
@maxx1128 maxx1128 deleted the va-17710-vba-schedule-appt-link branch April 29, 2024 15:07
eselkin added a commit that referenced this pull request May 14, 2024
@eselkin @maxx1128
Vacms 16144 VAMC service location paragraphs - and merge VBA (#1912)
53d7f85 
* Move to Service Location Paragraphs in VAMC

* merging of service_locations paragraphs

* Service Hours

* remove old service_location paragraphs

* remove consolelog

* typo on include

* conditions when to show Appointments

* show appointments simplification

* test not possible on paragraph

* testing

* naming

* spacing

* indent

* non-clinical

* clena up spacing

* spacing class

* improving spacing slowly

* spacing again

* working spacing

* more spacing

* correct order of phone numbers and h5 for appointment related phone numbers

* order

* borders were not showing

* bordered

* accidental vet center accordion border

* fix headers

* VA-15959: Update VBA Service Location query for int branch (#1936)

* fix for empty extensions

* v3 components added, built, updated

* remove extra vetcenter attributes to liquid

* fix testing on phone numbers now that using va-telephone component

* add more testing

* make use of regexes better

* explanation of matches

* allow for short codes

* additional info uswds

* spacing on Appointments header

* remove Vet Center tests from this branch

* remove Vet Center tests from this branch

* replace should have 2 args

* remove debugging

* remove extra div and strongs

* optional

* VACMS-17513: Remove unspecified referrals from front-end (#1982)

* shows main phone or appt phone numbers and shows main phone or contact phone numbers (#1993)

* Appointments top section visible when walkins unspecified and not remove_text (#2009)

* Appointments top section visible when walkins unspecified
* spacing
* simplify conditions -- no change in logic
* fix? works locally- did not push last time because of new package.json
* update to variables

* not elsif (#2002)

* VACMS 17632 no card on non-clinical service locations  (#2024)

* no card on non-clinical service locations
* remove comment
* updated spacing

* VACMS 17844 update service options values for office visits and virtual support (#2035)

* working values for updated office visits and virtual
* update comment

* VA-17710: Change Online Schedule link for VBA Services (#2026)

* memBefore memAfter

* trying graceful fs

* fix from VACMS-18069-EMFILE-error-memoryUsage

* VA-17598: Manage Benefits online link update (#2057)

* VA-17598: Add missing benefits paragraph (#2078)

* hasAddress default to false

---------

Co-authored-by: Max Antonucci <[email protected]>
Co-authored-by: Max Antonucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilladams jilladams jilladams left review comments

@eselkin eselkin eselkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxx1128 @eselkin @jilladams @va-vfs-bot