Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Display of Non-Clinical Services on VAMC Top Task Pages should not be in a Card component #17632

Closed
4 of 5 tasks
Tracked by #16825
davidmpickett opened this issue Mar 26, 2024 · 6 comments
Closed
4 of 5 tasks
Tracked by #16825
Assignees
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Mar 26, 2024

User Story or Problem Statement

In the tugboat Integration branch, non-clinical services on VAMC Top Task Pages are presenting inside a bordered box for Service Locations. This does not match the current design ( or future design, later).

Description or Additional Context

SCREENSHOTS Examples of 3 top task pages where the bordered box is visible, and needs to go away: ![screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-register-for-care-2024-03-25-22_08_15](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/01b372f7-dea8-43b5-b86b-e2a603283bab)

screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-billing-and-insurance-2024-03-25-22_08_07

screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-medical-records-office-2024-03-25-22_07_56

Steps for Implementation

Acceptance Criteria

  • Non-clinical service locations do not use the card component/border on these templates
    • Billing and Insurance
    • Medical Records
    • Register for Care
  • Requires design review
@davidmpickett davidmpickett added Needs refining Issue status Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team labels Mar 26, 2024
@davidmpickett davidmpickett added VA.gov frontend CMS team practice area UX labels Mar 26, 2024
@davidmpickett davidmpickett changed the title Consider: FE Display of Non-Clinical Services on VAMC Top Task Pages FE Display of Non-Clinical Services on VAMC Top Task Pages should reflect [TBD] Mar 28, 2024
This was referenced Apr 2, 2024
@jilladams jilladams changed the title FE Display of Non-Clinical Services on VAMC Top Task Pages should reflect [TBD] FE Display of Non-Clinical Services on VAMC Top Task Pages should reflect design [TBD] Apr 4, 2024
@davidmpickett davidmpickett changed the title FE Display of Non-Clinical Services on VAMC Top Task Pages should reflect design [TBD] FE Display of Non-Clinical Services on VAMC Top Task Pages should not be in a Card component Apr 4, 2024
@jilladams jilladams removed the Needs refining Issue status label Apr 10, 2024
@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@jilladams jilladams removed the UX label Apr 17, 2024
@eselkin eselkin self-assigned this Apr 17, 2024
@jilladams
Copy link
Contributor

This is in PR.
The Tugboat FE needs to be built from the PR branch in order to QA for merge.
That is queued behind Christian's rebuild for the Unspecified = NULL migration fix.

@thejordanwood
Copy link

I reviewed the PR for this and have approved it.

Following up on spacing: @eselkin Thanks for bringing up in scrum that the space between the location header and the facility address is 48px instead of the 45px specified in the design mockup. In this case, I'm fine with the difference since the VADS ecosystem doesn't have the 45px spacing.

@laflannery
Copy link
Contributor

laflannery commented Apr 23, 2024

I just want to note here for reference because it seems as though my direction on the PR looks to be in contrast to Jordan's comment above.

I am working off this Figma file in which the space between the Facility address and the "Location" header is 24px, which is just about the standard DS spacing (they actually state it should be 25.5px)
Screenshot 2024-04-23 at 12 04 14 PM

This is why I have recommended in my comment we remove the extra large spacing and custom spacing I was seeing and stick instead with the standard DS spacing.

@davidmpickett
Copy link
Contributor Author

This ticket was not supposed to include altering any spacing. it was only supposed to be about removing the border. I apologize for linking to a speculative WIP design as reference. By default, these should match the current spacing on Prod (which is 25.5)

Screenshot 2024-04-23 at 6 47 30 PM

@davidmpickett
Copy link
Contributor Author

Last step is verifying this on SL tugboat after the migration finished and Content Release runs

@davidmpickett
Copy link
Contributor Author

Confirmed on Tugboat
Screenshot 2024-04-29 at 10 01 46 PM
Screenshot 2024-04-29 at 10 02 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants