-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Display of Non-Clinical Services on VAMC Top Task Pages should not be in a Card component #17632
Comments
This is in PR. |
I reviewed the PR for this and have approved it. Following up on spacing: @eselkin Thanks for bringing up in scrum that the space between the location header and the facility address is 48px instead of the 45px specified in the design mockup. In this case, I'm fine with the difference since the VADS ecosystem doesn't have the 45px spacing. |
I just want to note here for reference because it seems as though my direction on the PR looks to be in contrast to Jordan's comment above. I am working off this Figma file in which the space between the Facility address and the "Location" header is 24px, which is just about the standard DS spacing (they actually state it should be 25.5px) This is why I have recommended in my comment we remove the extra large spacing and custom spacing I was seeing and stick instead with the standard DS spacing. |
Last step is verifying this on SL tugboat after the migration finished and Content Release runs |
User Story or Problem Statement
In the tugboat Integration branch, non-clinical services on VAMC Top Task Pages are presenting inside a bordered box for Service Locations. This does not match the current design ( or future design, later).
Description or Additional Context
SCREENSHOTS
Examples of 3 top task pages where the bordered box is visible, and needs to go away: ![screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-register-for-care-2024-03-25-22_08_15](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/01b372f7-dea8-43b5-b86b-e2a603283bab)Steps for Implementation
Acceptance Criteria
The text was updated successfully, but these errors were encountered: