Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VirtualHearingModal for timezone and email changes #14730

Closed
1 of 3 tasks
sahalliburton opened this issue Jul 17, 2020 · 0 comments · Fixed by #14743
Closed
1 of 3 tasks

Update VirtualHearingModal for timezone and email changes #14730

sahalliburton opened this issue Jul 17, 2020 · 0 comments · Fixed by #14743
Assignees
@sahalliburton
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃
Milestone
PI4-S6: Sea of Tr...

Comments

@sahalliburton
Copy link
Contributor

sahalliburton commented Jul 17, 2020 •
edited by nicholer
Loading

Description

Change the VirtualHearingModal to display email and timezone updates separately based on the figma diagram

Acceptance criteria

  • Ensure emails are sent only recipients whose email/timezone is updated with the corresponding email type
  • Add screenshots of UI changes

Technical Notes

Open Questions

  • Should there be a difference between the modals for previously Central and previously Video hearings? Yes, as long as formerly-video hearings don't take veteran and POA timezone into account, there will be a difference in the modals.
@sahalliburton sahalliburton added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Team: Tango 💃 labels Jul 17, 2020
@chandracarney chandracarney added the Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests label Jul 20, 2020
@sahalliburton sahalliburton self-assigned this Jul 21, 2020
@chandracarney chandracarney mentioned this issue Jul 21, 2020
Closed
@sahalliburton sahalliburton mentioned this issue Jul 21, 2020
Merged
5 tasks
va-bot pushed a commit that referenced this issue Jul 23, 2020
@sahalliburton
Started refactoring modal to only send emails based on updated fields (…
27c55c6 
…#14743)

Resolves #14730 

### Description
Updates virtual hearing modal to display differently based on Video or Central hearing as well as whether the user is editing Hearing Time, Timezone, or either POA/Representative Email or Appellant email.

### Acceptance Criteria
- [ ] Code compiles correctly

### Testing Plan

**Hearing Time**
1. Shadow user `BVASYELLOW`
1. Navigate to the hearing schedule and choose a 'Central' hearing
1. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
1. Navigate back to the daily docket and change the hearing time for this hearing
1. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

**Timezone/Email**
1. Shadow user `BVASYELLOW`
1. Navigate to the hearing schedule and choose a 'Central' hearing
1. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
1. Change either the timezone or the email for either the appellant or the POA/Representative
1. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

**Appellant and POA/Representative Timezone/Email**
1. Shadow user `BVASYELLOW`
1. Navigate to the hearing schedule and choose a 'Central' hearing
1. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
1. Change either the timezone or the email for both the appellant and the POA/Representative
1. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

### User Facing Changes
 - [x] Screenshots of UI changes added to PR & Original Issue

**Hearing Time**
![CentralChangeHearingTime](https://user-images.githubusercontent.com/61989526/88282263-2fb9ab00-ccb7-11ea-85f1-8d906b5f865e.png)

**Change Email or Timezone Appellant or Poa/Representative**
![AppellantChangeTimezoneOrEmail](https://user-images.githubusercontent.com/61989526/88282256-2af4f700-ccb7-11ea-9000-d42e9f2a5789.png)

**Change Email or Timezone Appellant and Poa/Representative**
![PoaAppellantChangeTimezoneOrEmail](https://user-images.githubusercontent.com/61989526/88282251-292b3380-ccb7-11ea-8b12-ae1be0e35f5c.png)

### Storybook Story
*For Frontend (Presentationa) Components*
* [x] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`)
* [x] Give it a title that reflects the component's location within the overall Caseflow hierarchy 
* [x] Write a separate story (within the same file) for each discrete variation of the component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahalliburton sahalliburton

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃
Projects
None yet
Milestone
PI4-S6: Sea of Tranquility Sprint
2 participants
@chandracarney @sahalliburton