Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started refactoring modal to only send emails based on updated fields #14743

Merged
merged 11 commits into from
Jul 23, 2020

Conversation

sahalliburton
Copy link
Contributor

@sahalliburton sahalliburton commented Jul 21, 2020

Resolves #14730

Description

Updates virtual hearing modal to display differently based on Video or Central hearing as well as whether the user is editing Hearing Time, Timezone, or either POA/Representative Email or Appellant email.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

Hearing Time

  1. Shadow user BVASYELLOW
  2. Navigate to the hearing schedule and choose a 'Central' hearing
  3. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
  4. Navigate back to the daily docket and change the hearing time for this hearing
  5. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

Timezone/Email

  1. Shadow user BVASYELLOW
  2. Navigate to the hearing schedule and choose a 'Central' hearing
  3. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
  4. Change either the timezone or the email for either the appellant or the POA/Representative
  5. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

Appellant and POA/Representative Timezone/Email

  1. Shadow user BVASYELLOW
  2. Navigate to the hearing schedule and choose a 'Central' hearing
  3. Click the 'Edit Hearing Details' link and change to a 'Virtual' hearing
  4. Change either the timezone or the email for both the appellant and the POA/Representative
  5. Ensure that the UI matches the figma mockup and that confirming the change triggers a UI alert

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue

Hearing Time
CentralChangeHearingTime

Change Email or Timezone Appellant or Poa/Representative
AppellantChangeTimezoneOrEmail

Change Email or Timezone Appellant and Poa/Representative
PoaAppellantChangeTimezoneOrEmail

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

@va-bot
Copy link
Collaborator

va-bot commented Jul 21, 2020

2 Warnings
⚠️ This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2020

Code Climate has analyzed commit 17c06e8 and detected 0 issues on this pull request.

View more on Code Climate.

@sahalliburton sahalliburton changed the title WIP: Started refactoring modal to only send emails based on updated fields Started refactoring modal to only send emails based on updated fields Jul 22, 2020
Copy link
Contributor

@ferristseng ferristseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The tests look really good too! I found one small thing I think where changing the representative email, and the appellant time leads to a modal that doesn't have a separator:

Screen Shot 2020-07-23 at 10 58 36 AM

@sahalliburton sahalliburton added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jul 23, 2020
@va-bot va-bot merged commit 27c55c6 into master Jul 23, 2020
@va-bot va-bot deleted the shalliburton/14730-timezone-modal branch July 23, 2020 16:30
@sahalliburton sahalliburton restored the shalliburton/14730-timezone-modal branch July 27, 2020 19:03
@alisan16 alisan16 deleted the shalliburton/14730-timezone-modal branch December 14, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update VirtualHearingModal for timezone and email changes
3 participants