-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started refactoring modal to only send emails based on updated fields #14743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Code Climate has analyzed commit 17c06e8 and detected 0 issues on this pull request. View more on Code Climate. |
…fairs/caseflow into shalliburton/14730-timezone-modal
sahalliburton
changed the title
WIP: Started refactoring modal to only send emails based on updated fields
Started refactoring modal to only send emails based on updated fields
Jul 22, 2020
ferristseng
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sahalliburton
added
the
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
label
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14730
Description
Updates virtual hearing modal to display differently based on Video or Central hearing as well as whether the user is editing Hearing Time, Timezone, or either POA/Representative Email or Appellant email.
Acceptance Criteria
Testing Plan
Hearing Time
BVASYELLOW
Timezone/Email
BVASYELLOW
Appellant and POA/Representative Timezone/Email
BVASYELLOW
User Facing Changes
Hearing Time
Change Email or Timezone Appellant or Poa/Representative
Change Email or Timezone Appellant and Poa/Representative
Storybook Story
For Frontend (Presentationa) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)