Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat(node/cluster): cluster module for Node compat (#2271)" #3111

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 15, 2023

This temporarily reverts #2271. #2271 requires access to some env vars (NODE_CLUSTER_SCHED_POLICY and NODE_UNIQUE_ID) at top level and that affects the all Deno programs (because std/node is loaded at start up of CLI).

closes denoland/deno#17414

@kt3k
Copy link
Member Author

kt3k commented Jan 15, 2023

We can avoid the requirements of env permission when Deno.permission.querySync (denoland/deno#17019) is available. We'll try to land this again when denoland/deno#17019 landed.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 13d469a into denoland:main Jan 15, 2023
@kt3k kt3k deleted the revert-node-cluster branch January 15, 2023 13:21
bartlomieju pushed a commit to bartlomieju/deno_std that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno asks for NODE_CLUSTER_SCHED_POLICY every time on deno run
2 participants