fix: revert "feat(node/cluster): cluster module for Node compat (de…

…noland#2271)" (denoland#3111)
bartlomieju · Feb 1, 2023 · 5c9ba20 · 5c9ba20
1 parent 04cee7c
commit 5c9ba20
Show file tree

Hide file tree

Showing 30 changed files with 99 additions and 2,342 deletions.
diff --git a/node/README.md b/node/README.md
@@ -124,30 +124,30 @@ $ deno run --allow-read --allow-net --allow-write node/_tools/setup.ts -n
 
 To run the tests you have set up, do the following:
 
-```shellsession
-$ deno test -A --unstable node/_tools/test.ts
+```zsh
+$ deno test --allow-read --allow-run node/_tools/test.ts
 ```
 
 If you want to run specific Node.js test files, you can use the following
 command
 
 ```shellsession
-$ deno test -A --unstable node/_tools/test.ts -- <pattern-to-match>
+$ deno test -A node/_tools/test.ts -- <pattern-to-match>
 ```
 
 For example, if you want to run only
 `node/_tools/test/parallel/test-event-emitter-check-listener-leaks.js`, you can
 use:
 
 ```shellsession
-$ deno test -A --unstable node/_tools/test.ts -- test-event-emitter-check-listener-leaks.js
+$ deno test -A node/_tools/test.ts -- test-event-emitter-check-listener-leaks.js
 ```
 
 If you want to run all test files which contains `event-emitter` in filename,
 then you can use:
 
 ```shellsession
-$ deno test -A --unstable node/_tools/test.ts -- event-emitter
+$ deno test -A node/_tools/test.ts -- event-emitter
 ```
 
 The test should be passing with the latest deno, so if the test fails, try the

diff --git a/node/_events.d.ts b/node/_events.d.ts
@@ -289,10 +289,6 @@ interface StaticEventEmitterOptions {
  * @since v0.1.26
  */
 export class EventEmitter {
-  _events: any;
-  _eventsCount: any;
-  _maxListeners: any;
-
   /**
    * Alias for `emitter.on(eventName, listener)`.
    * @since v0.1.26

diff --git a/node/_fs/_fs_access_test.ts b/node/_fs/_fs_access_test.ts
@@ -8,7 +8,7 @@ Deno.test(
   async () => {
     const file = await Deno.makeTempFile();
     try {
-      await Deno.chmod(file, 0o600);
+      Deno.chmod(file, 0o600);
       await fs.promises.access(file, fs.constants.R_OK);
       await fs.promises.access(file, fs.constants.W_OK);
       await assertRejects(async () => {
@@ -40,7 +40,7 @@ Deno.test(
   () => {
     const file = Deno.makeTempFileSync();
     try {
-      Deno.chmodSync(file, 0o600);
+      Deno.chmod(file, 0o600);
       fs.accessSync(file, fs.constants.R_OK);
       fs.accessSync(file, fs.constants.W_OK);
       assertThrows(() => {

diff --git a/node/_tools/TODO.md b/node/_tools/TODO.md
@@ -3,7 +3,7 @@
 NOTE: This file should not be manually edited. Please edit `config.json` and run
 `deno task node:setup` instead.
 
-Total: 2804
+Total: 2811
 
 - [abort/test-abort-backtrace.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-backtrace.js)
 - [abort/test-abort-fatal-error.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-fatal-error.js)
@@ -363,6 +363,8 @@ Total: 2804
 - [parallel/test-cluster-bind-privileged-port.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-bind-privileged-port.js)
 - [parallel/test-cluster-bind-twice.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-bind-twice.js)
 - [parallel/test-cluster-call-and-destroy.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-call-and-destroy.js)
+- [parallel/test-cluster-child-index-dgram.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-child-index-dgram.js)
+- [parallel/test-cluster-child-index-net.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-child-index-net.js)
 - [parallel/test-cluster-concurrent-disconnect.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-concurrent-disconnect.js)
 - [parallel/test-cluster-cwd.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-cwd.js)
 - [parallel/test-cluster-dgram-1.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-dgram-1.js)
@@ -372,8 +374,11 @@ Total: 2804
 - [parallel/test-cluster-dgram-reuse.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-dgram-reuse.js)
 - [parallel/test-cluster-disconnect-before-exit.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-before-exit.js)
 - [parallel/test-cluster-disconnect-exitedAfterDisconnect-race.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-exitedAfterDisconnect-race.js)
+- [parallel/test-cluster-disconnect-idle-worker.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-idle-worker.js)
 - [parallel/test-cluster-disconnect-leak.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-leak.js)
 - [parallel/test-cluster-disconnect-race.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-race.js)
+- [parallel/test-cluster-disconnect-unshared-tcp.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-unshared-tcp.js)
+- [parallel/test-cluster-disconnect-unshared-udp.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-unshared-udp.js)
 - [parallel/test-cluster-disconnect-with-no-workers.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect-with-no-workers.js)
 - [parallel/test-cluster-disconnect.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-disconnect.js)
 - [parallel/test-cluster-eaccess.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-eaccess.js)
@@ -398,6 +403,7 @@ Total: 2804
 - [parallel/test-cluster-primary-error.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-primary-error.js)
 - [parallel/test-cluster-primary-kill.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-primary-kill.js)
 - [parallel/test-cluster-process-disconnect.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-process-disconnect.js)
+- [parallel/test-cluster-rr-domain-listen.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-rr-domain-listen.js)
 - [parallel/test-cluster-rr-ref.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-rr-ref.js)
 - [parallel/test-cluster-send-deadlock.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-send-deadlock.js)
 - [parallel/test-cluster-send-handle-twice.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-send-handle-twice.js)
@@ -424,6 +430,7 @@ Total: 2804
 - [parallel/test-cluster-worker-handle-close.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-handle-close.js)
 - [parallel/test-cluster-worker-init.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-init.js)
 - [parallel/test-cluster-worker-isconnected.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-isconnected.js)
+- [parallel/test-cluster-worker-isdead.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-isdead.js)
 - [parallel/test-cluster-worker-kill-signal.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-kill-signal.js)
 - [parallel/test-cluster-worker-kill.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-kill.js)
 - [parallel/test-cluster-worker-no-exit.js](https://github.com/nodejs/node/tree/v18.12.1/test/parallel/test-cluster-worker-no-exit.js)

diff --git a/node/_tools/config.json b/node/_tools/config.json
@@ -202,13 +202,6 @@
       "test-child-process-spawnsync-validation-errors.js",
       "test-child-process-spawnsync.js",
       "test-client-request-destroy.js",
-      "test-cluster-child-index-dgram.js",
-      "test-cluster-child-index-net.js",
-      "test-cluster-disconnect-idle-worker.js",
-      "test-cluster-disconnect-unshared-tcp.js",
-      "test-cluster-disconnect-unshared-udp.js",
-      "test-cluster-rr-domain-listen.js",
-      "test-cluster-worker-isdead.js",
       "test-console-async-write-error.js",
       "test-console-group.js",
       "test-console-instance.js",

diff --git a/node/_tools/require.mjs b/node/_tools/require.mjs
diff --git a/node/_tools/test.ts b/node/_tools/test.ts
@@ -88,7 +88,7 @@ for await (const path of testPaths) {
         console.log(`Error: "${path}" failed`);
         console.log(
           "You can repeat only this test with the command:",
-          magenta(`deno test -A --unstable node/_tools/test.ts -- ${path}`),
+          magenta(`deno test -A node/_tools/test.ts -- ${path}`),
         );
         fail(decodedStderr);
       }

diff --git a/node/_tools/test/parallel/test-cluster-child-index-dgram.js b/node/_tools/test/parallel/test-cluster-child-index-dgram.js
diff --git a/node/_tools/test/parallel/test-cluster-child-index-net.js b/node/_tools/test/parallel/test-cluster-child-index-net.js
diff --git a/node/_tools/test/parallel/test-cluster-disconnect-idle-worker.js b/node/_tools/test/parallel/test-cluster-disconnect-idle-worker.js
diff --git a/node/_tools/test/parallel/test-cluster-disconnect-unshared-tcp.js b/node/_tools/test/parallel/test-cluster-disconnect-unshared-tcp.js
diff --git a/node/_tools/test/parallel/test-cluster-disconnect-unshared-udp.js b/node/_tools/test/parallel/test-cluster-disconnect-unshared-udp.js