Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): prevent leak of permission requirement #3112

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 15, 2023

This test case detects the error like denoland/deno#17414, and prevents similar errors

This PR will pass the CI when the current env permission error is fixed in CLI (needs another release) and STD ( #3111 ) repos.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice!

@kt3k kt3k merged commit ec2f37c into denoland:main Jan 23, 2023
@kt3k kt3k deleted the check-permission-leak branch January 23, 2023 09:18
bartlomieju pushed a commit to crowlKats/deno_std that referenced this pull request Jan 26, 2023
bartlomieju pushed a commit to bartlomieju/deno_std that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants