Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include version number in all --json based outputs #25335

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Sep 1, 2024

Edit: A structure changed a lot since I submitted the original PR, and I unfortunately do not have time to fix the tests on top of latest changes right now. cc @bartlomieju

resubmit of #17780

Affected commands:

  • deno doc --json
  • deno info --json
  • deno lint --json
  • deno lint --json --rules
  • deno bench --json

Things to note:

  • [WILDCARD] could be replaced with [WILDCARD].[WILDCARD].[WILDCARD] for more accurate assertion
  • breaking: doc --json returns the output under nodes now
  • breaking: lint --json returns the output under rules now
  • missing bench --json test, as I couldn't get it running 🤔

Resolves #17774

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) September 5, 2024 08:31
@dsherret dsherret merged commit 2c4d99a into denoland:main Sep 5, 2024
17 checks passed
@kamilogorek kamilogorek deleted the json-version branch September 5, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version numbers to all --json output
3 participants