Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version numbers to all --json output #17774

Closed
dsherret opened this issue Feb 14, 2023 · 0 comments · Fixed by #25335
Closed

Add version numbers to all --json output #17774

dsherret opened this issue Feb 14, 2023 · 0 comments · Fixed by #25335
Labels
suggestion suggestions for new features (yet to be agreed)
Milestone

Comments

@dsherret
Copy link
Member

dsherret commented Feb 14, 2023

We should include a version number (not the deno version) in all --json output.

{
  "version": 1,
  // rest of properties
}

When we do a backwards incompatible change (which is unfortunately inevitable), we should bump this version for the specific output. The output would then be versioned by this number and not by the CLI version.

This will allow tools that use this information to only have to check this number to quickly tell if they have support for certain output and not have to sniff the CLI version and know which CLI version something changed.

Related: denoland/deno_graph#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
1 participant