-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include version number in all --json based outputs #17780
Conversation
Ah, gotcha. Thought that maybe detecting deno version that generated the output is sufficient. Updated.
Actually, lets do this, so it's easier to modify in the future. |
Breaking changes in the |
Yes, the original issue was for 2.0. |
Needs rebase, and then of course have to wait for a major version change :) |
Ping me once it's ready for 2.0, so I don't have to rebase multiple times :) |
@kamilogorek is there a particular reason you deleted the fork repo? We're on the verge of Deno 2 and wanted to merge this PR. Should we open a new one then? |
I might've gone too far pruning stale PRs on my GitHub account 😅 resubmitted as #25335 |
Affected commands:
deno doc --json
deno info --json
deno lint --json
deno lint --json --rules
deno bench --json
Things to note:
[WILDCARD]
could be replaced with[WILDCARD].[WILDCARD].[WILDCARD]
for more accurate assertiondoc --json
returns the output undernodes
nowlint --json
returns the output underrules
nowbench --json
test, as I couldn't get it running 🤔Resolves #17774