fix(ops): add node.js env variable allowlist #15893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the Node compatibility layer to skip environment variable permission checks when --unstable is passed and the variable name is one that Node uses. Fixes: #15890
ry
reviewed
Sep 13, 2022
ext/node/lib.rs
Outdated
Comment on lines
85
to
87
| set.insert("OPENSSL_CONF".to_string()); | ||
| set.insert("SSL_CERT_DIR".to_string()); | ||
| set.insert("SSL_CERT_FILE".to_string()); |
There was a problem hiding this comment.
these potentially have security implications
There was a problem hiding this comment.
Does that mean you'd like me to remove them?
There was a problem hiding this comment.
Maybe we should keep this list really short for now and only allow the env vars that cause a lot of prompts/pain?
There was a problem hiding this comment.
OK. I've made the list significantly smaller.
cjihrig
added a commit
that referenced
this pull request
Sep 15, 2022
This commit allows the Node compatibility layer to skip environment variable permission checks when --unstable is passed and the variable name is one that Node uses. Fixes: #15890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the Node compatibility layer to skip environment variable permission checks when --unstable is passed and the variable name is one that Node uses.
Fixes: #15890