Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): don't unnecessarily ask for env access #3132

Closed
wants to merge 4 commits into from
Closed

fix(node): don't unnecessarily ask for env access #3132

wants to merge 4 commits into from

Conversation

lino-levan
Copy link
Contributor

Props to @iuioiua for getting querySync landed (denoland/deno#17019).

Closes #2446.

@lino-levan lino-levan requested a review from kt3k as a code owner January 25, 2023 00:08
@lino-levan lino-levan changed the title fix: don't unnecessarily ask for env variable fix(node): don't unnecessarily ask for env access Jan 25, 2023
@lino-levan
Copy link
Contributor Author

Canary is quite literally not built yet, this should pass when it is finished.

@iuioiua
Copy link
Contributor

iuioiua commented Jan 25, 2023

Quick turnaround! 🚀😳

@kt3k
Copy link
Member

kt3k commented Jan 26, 2023

Looks good to me. Thanks for your contribution!

But now this is blocked by Deno Deploy compatibility as it doesn't have querySync yet. Let's wait until it updates permissions API

@kt3k
Copy link
Member

kt3k commented Jan 26, 2023

BTW currently we exceptionally skip checking env permission for this particular env variable. See denoland/deno#15893

Maybe we should remove that exceptional handling in CLI after this landed. (@bartlomieju What do you think about this?)

@bartlomieju
Copy link
Member

BTW currently we exceptionally skip checking env permission for this particular env variable. See denoland/deno#15893

Maybe we should remove that exceptional handling in CLI after this landed. (@bartlomieju What do you think about this?)

Sure, sounds good to me!

@kt3k kt3k mentioned this pull request Jan 29, 2023
Closed
kt3k
kt3k reviewed Feb 9, 2023
View reviewed changes
node/internal/util/debuglog.ts Outdated Show resolved Hide resolved
@iuioiua
Copy link
Contributor

iuioiua commented Mar 2, 2023

Can we re-create this PR in the main repo if it's still needed?

@lino-levan
Copy link
Contributor Author

Closing this PR as it is stale.

@lino-levan lino-levan closed this Mar 2, 2023
@lino-levan lino-levan deleted the fix-debuglog branch March 14, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't unnecessarily request to read environment variable
4 participants
@lino-levan @iuioiua @kt3k @bartlomieju