Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allow-list for special env vars like NODE_DEBUG #15890

Closed
ry opened this issue Sep 13, 2022 · 0 comments · Fixed by #15893
Closed

add allow-list for special env vars like NODE_DEBUG #15890

ry opened this issue Sep 13, 2022 · 0 comments · Fixed by #15893
Assignees
@cjihrig

Comments

@ry
Copy link
Member

ry commented Sep 13, 2022

https://github.com/denoland/deno_std/blob/24ef3e54d8eed46eae1a301684cd64f7a87e5b98/node/_process/process.ts#L74
@cjihrig cjihrig mentioned this issue Sep 13, 2022
Merged
cjihrig added a commit that referenced this issue Sep 14, 2022
@cjihrig
fix(ops): add node.js env variable allowlist (#15893)
19deec4 
This commit allows the Node compatibility layer to skip
environment variable permission checks when --unstable
is passed and the variable name is one that Node uses.

Fixes: #15890
cjihrig added a commit that referenced this issue Sep 15, 2022
@cjihrig
fix(ops): add node.js env variable allowlist (#15893)
e90f42c 
This commit allows the Node compatibility layer to skip
environment variable permission checks when --unstable
is passed and the variable name is one that Node uses.

Fixes: #15890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjihrig cjihrig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ops): add node.js env variable allowlist cjihrig/deno
2 participants
@ry @cjihrig