Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in ext\http\http_next.rs:195:1 #19058

Closed
kigiri opened this issue May 9, 2023 · 1 comment · Fixed by #19154
Closed

Panic in ext\http\http_next.rs:195:1 #19058

kigiri opened this issue May 9, 2023 · 1 comment · Fixed by #19154
Assignees
@mmastrac

Comments

@kigiri
Copy link

kigiri commented May 9, 2023

My app crashes sometimes, code I was testing with using is https://github.com/devazuka/noscroll/blob/0b1167617df32ba1f7740b64f02774e23020ca60/noscroll.js

I don't have a lot of space left on disk, might be the problem, will try to reproduce on linux.

Platform: windows x86_64
Version: 1.33.2
Args: ["C:\\Users\\cd\\scoop\\apps\\deno\\current\\deno.exe", "run", "--unstable", "-A", ".\\noscroll.js"]

thread 'main' panicked at 'Attemped to access invalid request 0 (0 in total available)', ext\http\http_next.rs:195:1

stack backtrace:

   0:     0x7ff743667aa9 - napi_release_threadsafe_function
   1:     0x7ff742808f9b - napi_release_threadsafe_function
   2:     0x7ff74364232a - napi_release_threadsafe_function
   3:     0x7ff74366c1bb - napi_release_threadsafe_function
   4:     0x7ff74366bdb1 - napi_release_threadsafe_function
   5:     0x7ff74366b9c5 - napi_release_threadsafe_function
   6:     0x7ff7426a05cc - napi_fatal_error
   7:     0x7ff74366ca07 - napi_release_threadsafe_function
   8:     0x7ff74366c776 - napi_release_threadsafe_function
   9:     0x7ff74366c6bf - napi_release_threadsafe_function
  10:     0x7ff74366c694 - napi_release_threadsafe_function
  11:     0x7ff7448e1255 - CrashForExceptionInNonABICompliantCodeRange
  12:     0x7ff742cc823e - napi_release_threadsafe_function
  13:     0x7ff743bf142b - CrashForExceptionInNonABICompliantCodeRange
  14:     0x7ff743bf0ae1 - CrashForExceptionInNonABICompliantCodeRange
  15:     0x7ff744682a3a - CrashForExceptionInNonABICompliantCodeRange
  16:     0x7ff7445ed99c - CrashForExceptionInNonABICompliantCodeRange
  17:     0x7ff7446295c3 - CrashForExceptionInNonABICompliantCodeRange
  18:     0x7ff7446ec331 - CrashForExceptionInNonABICompliantCodeRange
  19:     0x7ff744617aea - CrashForExceptionInNonABICompliantCodeRange
  20:     0x7ff7445eb8d7 - CrashForExceptionInNonABICompliantCodeRange
  21:     0x7ff743a12590 - napi_release_threadsafe_function
  22:     0x7ff743a13175 - napi_release_threadsafe_function
  23:     0x7ff743a133c3 - napi_release_threadsafe_function
  24:     0x7ff743af04b4 - CrashForExceptionInNonABICompliantCodeRange
  25:     0x7ff743af02f3 - CrashForExceptionInNonABICompliantCodeRange
  26:     0x7ff7429b683e - napi_release_threadsafe_function
  27:     0x7ff743bf142b - CrashForExceptionInNonABICompliantCodeRange
  28:     0x7ff743bf0ae1 - CrashForExceptionInNonABICompliantCodeRange
  29:     0x7ff744682a3a - CrashForExceptionInNonABICompliantCodeRange
  30:     0x7ff6c48cd4de - <unknown>
  31:     0x7ff7445eb9dc - CrashForExceptionInNonABICompliantCodeRange
  32:     0x7ff7445eb5d7 - CrashForExceptionInNonABICompliantCodeRange
  33:     0x7ff743a12618 - napi_release_threadsafe_function
  34:     0x7ff743a11e1e - napi_release_threadsafe_function
  35:     0x7ff7438d454e - napi_release_threadsafe_function
  36:     0x7ff7438b7a30 - napi_release_threadsafe_function
  37:     0x7ff742a07b6a - napi_release_threadsafe_function
  38:     0x7ff7429f6b18 - napi_release_threadsafe_function
  39:     0x7ff74223bc39 - <unknown>
  40:     0x7ff742662778 - napi_fatal_error
  41:     0x7ff74263405c - napi_fatal_error
  42:     0x7ff74267a4c9 - napi_fatal_error
  43:     0x7ff7426a5045 - napi_fatal_error
  44:     0x7ff742332536 - napi_cancel_async_work
  45:     0x7ff7422389f4 - <unknown>
  46:     0x7ff7426a119f - napi_fatal_error
  47:     0x7ff7422841a2 - <unknown>
  48:     0x7ff742788853 - napi_release_threadsafe_function
  49:     0x7ff74489438c - CrashForExceptionInNonABICompliantCodeRange
  50:     0x7ffc5d337604 - BaseThreadInitThunk
  51:     0x7ffc5d5226a1 - RtlUserThreadStart
@mmastrac
Copy link
Contributor

Working on this in #19154

This was referenced May 16, 2023
Closed
Merged
@mmastrac mmastrac linked a pull request May 16, 2023 that will close this issue
fix(ext/http): Ensure cancelled requests don't crash Deno.serve #19154
Merged
mmastrac added a commit that referenced this issue May 16, 2023
@mmastrac
fix(ext/http): Ensure cancelled requests don't crash Deno.serve (#19154)
a22388b 
Fixes for various `Attemped to access invalid request` bugs (#19058,
#15427, #17213).

We did not wait for both a drop event and a completion event before
removing items from the slab table. This ensures that we do so.

In addition, the slab methods are refactored out into `slab.rs` for
maintainability.
levex pushed a commit that referenced this issue May 18, 2023
@mmastrac @levex
fix(ext/http): Ensure cancelled requests don't crash Deno.serve (#19154)
48df2f5 
Fixes for various `Attemped to access invalid request` bugs (#19058,
#15427, #17213).

We did not wait for both a drop event and a completion event before
removing items from the slab table. This ensures that we do so.

In addition, the slab methods are refactored out into `slab.rs` for
maintainability.
@mmastrac mmastrac mentioned this issue May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmastrac mmastrac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/http): Ensure cancelled requests don't crash Deno.serve mmastrac/deno
2 participants
@kigiri @mmastrac