Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in new HTTP server #19196

Closed
lucacasonato opened this issue May 19, 2023 · 4 comments
Closed

Panic in new HTTP server #19196

lucacasonato opened this issue May 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working correctly

Comments

@lucacasonato
Copy link
Member

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: macos aarch64
Version: 1.33.3
Args: ["/Users/lucacasonato/.deno/bin/deno", "run", "-A", "--unstable", "--watch", "main.ts"]

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', ext/http/http_next.rs:196:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I was just refreshing somewhat quickly - not quite sure what caused it.

@lucacasonato lucacasonato added the bug Something isn't working correctly label May 19, 2023
@lucacasonato
Copy link
Member Author

with_req should handle invalid (already closed) req ids correctly (gracefully error) instead of panicing.

@bartlomieju
Copy link
Member

Does it actually happen on v1.33.4? I think a22388b might have already fixed that problem.

@mmastrac
Copy link
Contributor

mmastrac commented May 19, 2023

I am pretty sure this is fixed by a22388b. Refreshing quickly was causing a request to get dropped, which removed it from the slab before we could complete it. There's a test for this particular failure in there now that was failing before and I'm unable to repro after.

@mmastrac
Copy link
Contributor

Mostly likely a dupe of #19058 -- will close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants