fix(ext/http): Ensure cancelled requests don't crash Deno.serve #19154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
This was referenced May 16, 2023
Closed
mmastrac
changed the title
mmastrac
changed the title
This was
linked to
issues
May 16, 2023
Closed
mmastrac
commented
May 16, 2023
| @@ -12,6 +12,7 @@ description = "HTTP server implementation for Deno" | |||
|
|
|||
| [features] | |||
| "__zombie_http_tracking" = [] | |||
| "__http_tracing" = [] | |||
There was a problem hiding this comment.
Useful flag to ensure we're not leaking requests
bartlomieju
reviewed
May 16, 2023
bartlomieju
approved these changes
May 16, 2023
levex
pushed a commit
that referenced
this pull request
May 18, 2023
Fixes for various `Attemped to access invalid request` bugs (#19058, #15427, #17213). We did not wait for both a drop event and a completion event before removing items from the slab table. This ensures that we do so. In addition, the slab methods are refactored out into `slab.rs` for maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for various
Attemped to access invalid requestbugs (#19058, #15427, #17213).We did not wait for both a drop event and a completion event before removing items from the slab table. This ensures that we do so.
In addition, the slab methods are refactored out into
slab.rsfor maintainability.