fix: ignore binary columns for stats generation #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when trying to checkpoint a table with a binary column, this will fail with
data type Binary not supported. This appears to be due to an arrow transformation into JSON to serialize the checkpoint format, and thatarrow-jsondoesn't support binary (https://github.com/apache/arrow-rs/blob/master/arrow-json/src/writer.rs#L213).This is a targeted fix that just disables stats generation for binary columns, which (at least to me) doesn't really make sense anyhow. This is a more targeted fix than #1498 and currently all the tests pass.
Related Issue(s)
#1498