Skip to content

Commit

Permalink
feat: ignore binary columns for stats generation
Browse files Browse the repository at this point in the history
  • Loading branch information
emcake authored and rtyler committed Oct 25, 2023
1 parent cffc4d7 commit 3d85b9b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions rust/src/schema/arrow_convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,8 @@ fn max_min_schema_for_fields(dest: &mut Vec<ArrowField>, f: &ArrowField) {
true,
));
}
// don't compute min or max for list or map types
ArrowDataType::List(_) | ArrowDataType::Map(_, _) => { /* noop */ }
// don't compute min or max for list, map or binary types
ArrowDataType::List(_) | ArrowDataType::Map(_, _) | ArrowDataType::Binary => { /* noop */ }
_ => {
let f = f.clone();
dest.push(f);
Expand Down Expand Up @@ -989,6 +989,7 @@ mod tests {
),
true,
),
ArrowField::new("binary", ArrowDataType::Binary, true),
];

let expected = vec![fields[0].clone(), fields[1].clone()];
Expand Down

0 comments on commit 3d85b9b

Please sign in to comment.