Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore binary columns for stats generation #1766

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: ignore binary columns for stats generation #1766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rust/src/schema/arrow_convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,8 @@ fn max_min_schema_for_fields(dest: &mut Vec<ArrowField>, f: &ArrowField) {
true,
));
}
// don't compute min or max for list or map types
ArrowDataType::List(_) | ArrowDataType::Map(_, _) => { /* noop */ }
// don't compute min or max for list, map or binary types
ArrowDataType::List(_) | ArrowDataType::Map(_, _) | ArrowDataType::Binary => { /* noop */ }
_ => {
let f = f.clone();
dest.push(f);
Expand Down Expand Up @@ -989,6 +989,7 @@ mod tests {
),
true,
),
ArrowField::new("binary", ArrowDataType::Binary, true),
];

let expected = vec![fields[0].clone(), fields[1].clone()];
Expand Down
Loading