Fixes/propertydictionaryitemservice offset #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug DB command timeout
* Get all associated items * sqlAssoсTiations -> sqlAssociations * Checked if AssociatedItemId is not null * Take into account ProductAssociationSearchCriteria.Group when search and do not return product variations Minor architectural refactoring * Added separated DAL for work with properties dictionary items * Convert the associations query to run as sql command with parameters
…lues instead of null even if passed response group doesn't contain relevant flag.
…mmerce#175) * Added infinite scrolling for dictionary properties. * Eliminated possibility to select items twice. * Setting page size via page-size attribute now works well. * Fixed dictionary value duplications if pageSize exceeds total dictionary value. * va-property2 templates: replaced hardcoded placeholders with translatable resource strings from platform. * Fixed: lazy-loading ignored search string and attempted to load all values, even for very specific search strings. * Reduced refresh timeout from 1000 to 200 ms. Now search keyword will be applied quicker. * small bug fixes
… (duplicated data in database when saving and displayed invalid values in UI)
… use custom views for product details
* Added $scope.options.isItemSelectable * Show thumbnail image
…rch provider RawQuery (VirtoCommerce#178)
Add caching for PropertyDictionaryItemService
… the aggregation filters doesn't interpret as 'need to use all values'
…ch controller method VirtoCommerce#180
… search products by their variation codes.
* Done * null checks for hidden languages * markup fix
* - Fixed FK violation on import by changing export order + resolving property CatalogId and CategoryId after they are created; - PropertyEntity.Patch: CategoryId and CatalogId are filled from source entity now; - Fixed Sonar warnings with redundant parameters and string.Format(); - Replaced "..." with "…" (single symbol alt+0133 on numpad); * Minor code refactoring * Cleanup
* VirtoCommerce#185 Added catalog property dictionary item sort order * VirtoCommerce#185 Catalog property dictionary items sorting * VirtoCommerce#185 Greater value of catalog property dictionary item sort order is going first * VirtoCommerce#185 Sorting catalog product, category and catalog dictionary property values by SortOrder parameter then by name/alias * VirtoCommerce#185 SortOrder for catalog property dictionary items is ascending * VirtoCommerce#185 Item, category and catalog sort order is ascending * Fix SortOrder input type to numeric * Update VirtoCommerce.Core version to 2.25.18 in module.manifest
- Removed unused code in CategoryConverter;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for all property dictionary items using the propertyDictionaryItemService, it seems that a combination of sorting and paging on the produced EF query returns unstable (duplicate) results.
This behaviour got introduced when an additional sort was added in commit VirtoCommerce@56fb799d
I was able to mitigate the issue by forcing a parameterized query but the root cause why SQL is returning unstable results is unknown to me.
Reproducible by executing the queries in following file and comparing the result sets:
EFReproductionQueries.zip