Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#189: Fixed catalog import SQL error #190

Merged
merged 3 commits into from
Dec 25, 2018
Merged

#189: Fixed catalog import SQL error #190

merged 3 commits into from
Dec 25, 2018

Conversation

yecli
Copy link
Contributor

@yecli yecli commented Dec 24, 2018

  • Fixed FK violation on import by changing export order + resolving property CatalogId and CategoryId after they are created;
  • PropertyEntity.Patch: CategoryId and CatalogId are filled from source entity now;
  • Fixed Sonar warnings with redundant parameters and string.Format();
  • Replaced "..." with "…" (single symbol alt+0133 on numpad);

@yecli
- Fixed FK violation on import by changing export order + resolving p…
5a89ea0 
…roperty CatalogId and CategoryId after they are created;

- PropertyEntity.Patch: CategoryId and CatalogId are filled from source entity now;
- Fixed Sonar warnings with redundant parameters and string.Format();
- Replaced "..." with "…" (single symbol alt+0133 on numpad);
@tatarincev tatarincev merged commit 61ea9d5 into dev Dec 25, 2018
@tatarincev tatarincev deleted the features/189-catalog-export-import-fk-violation branch December 25, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatarincev tatarincev tatarincev approved these changes

@pushnitsa pushnitsa Awaiting requested review from pushnitsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yecli @tatarincev