185 sort catalog properties #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
artem-dudarev
requested changes
Dec 17, 2018
| @@ -121,7 +121,7 @@ public GenericSearchResult<PropertyDictionaryItem> Search(PropertyDictionaryItem | |||
| var sortInfos = criteria.SortInfos; | |||
| if (sortInfos.IsNullOrEmpty()) | |||
| { | |||
| sortInfos = new[] { new SortInfo { SortColumn = "SortOrder" } }; | |||
| sortInfos = new[] { new SortInfo { SortColumn = "SortOrder", SortDirection = SortDirection.Descending } }; | |||
There was a problem hiding this comment.
This is incorrect.
Sort by SortOrder then by Alias
There was a problem hiding this comment.
Added second sort info - by Alias
There was a problem hiding this comment.
Changed to ascending
tatarincev
reviewed
Dec 17, 2018
…y values by SortOrder parameter then by name/alias
artem-dudarev
requested changes
Dec 17, 2018
|
What about other 3 places? |
|
I have told with Eugene and double checked this issue from the storefront. And how do you think - should it be described in the task requirements and not in the comments after? I mean sort direction, second sort criteria and so on. |
|
The issue description doesn't require to sort with descending order. So there was no need to introduce such sorting. |
tatarincev
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.zenhub.com/workspaces/vc-operations-564a7a2e8294d8de6364f3d7/issues/virtocommerce/vc-module-catalog/185