-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor away from aws blueprints + add custom vpc_cni #96
Conversation
Looks like you are doing updates to the My next step after merging #90 was to delete those two existing examples (first Adding another example on top concerns me, as it looks to be a lot of copy/pasted code again, which is going to negatively affect maintainability. Understand that this is very much a WIP PR, but want to make sure we aren't moving in opposite directions. |
Yeah I wasn't intending for that folder to make it into main. Just extra scratch space as I worked through some of the new variables and logic while still looking at the old examples |
/test all |
/test all |
/test all |
/test all |
/test all |
/test all |
/test all |
/test all |
/test all |
Signed-off-by: Zack A <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security features don't have parity but everything else looks good!
Will update existing EKS security group issue #17 and add others as needed to capture the delta
This PR refactors the meat of the EKS cluster and nodes to the upstream aws terraform module - terraform-aws-eks away from blueprints.
The main reason for this is that most of the AWS blueprints functionality is being deprecated, see https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/docs/v5-direction/DIRECTION_v5.md#notable-changes
With this change we are also adding the ability to configure eks native
cluster_addons
with the ability to configure and deploy eks add-ons before nodegroups are deployed.Breaking changes to EKS module
Name changes were made to many of the inputs and outputs from the eks module. These were made to have parity with the new upstream module.
Changes to the
complete
exampleCan now deploy
eks managed
andself managed
node groups, but also has the ability to do one or none based on the inputsenable_self_managed_nodegroups
andenable_eks_managed_nodegroups
and had been refactored to use the new eks module.Zarf example
This will break the zarf example, the intention is to go back and fix that in another pr and fix all the inputs.
This PR closes #73 and supports #75