Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EKS module to conform to EKS Blueprints direction #73

Closed
ntwkninja opened this issue Feb 15, 2023 · 5 comments · Fixed by #96
Closed

Change EKS module to conform to EKS Blueprints direction #73

ntwkninja opened this issue Feb 15, 2023 · 5 comments · Fixed by #96
Assignees

Comments

@ntwkninja
Copy link
Member

https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/docs/v5-direction/DIRECTION_v5.md#notable-changes

@RothAndrew
Copy link
Member

More info needed. @zack-is-cool are you working on stuff for this already? I remember you had mentioned it. Need better context on what is needed and what is already being worked.

@zack-is-cool
Copy link
Member

Currently working it in branch: https://github.com/defenseunicorns/iac/tree/calico_cni which will be a refactor from using aws-blueprints for the EKS cluster + worker node/kms deployments to using the upstream terraform-aws-eks module. One of the main reasons for this refactor is that the upstream terraform-aws-eks module has an extra switch for deploying and configuring an EKS addons before the worker nodes are deployed, specifically configuring vpc-cni on the cluster before nodes are deployed. A benefit from this is that the pods can be configured to utilize a different subnet than the worker nodes, this will deal with ip exhaustion issues that have come from downstream projects.

We'll also be using calico to utilize network policies.
relevant links:
aws calico
calico on aws eks

@ntwkninja anything I'm missing here?

@RothAndrew
Copy link
Member

@zack-is-cool would you mind pushing up a draft PR?

Will this work that you are doing also cover #75?

@ntwkninja
Copy link
Member Author

spot on @zack-is-cool

VPC CNI with custom networking + calico CNI could not be deployed with EKS blueprints because it was missing the before_compute flag and EKS blueprints has pivoted so we couldn't work an upstream PR

@RothAndrew Zack is working #73 & #75

@RothAndrew
Copy link
Member

Sounds good. Recommend we get the automated testing stuff in place before a big change like this gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants