-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Automated testing #90
Conversation
Signed-off-by: jase koonce <[email protected]>
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not merging until @RothAndrew decides too. Approved!
Waiting for at least 1 more person to review and approve, preferably @zack-is-cool. Zack, let me know when you get around to looking at this, I'd like to pair up with you and look at it together |
/test all |
Signed-off-by: Andy Roth <[email protected]>
/test all |
@zack-is-cool LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good to me. +1 for pairing session.
/test all |
/test all |
BLUF
complete
that is capable of running in either "insecure mode" or "secure mode" by switching which tfvars overlay is used. Insecure mode is ready as part of this PR, secure mode will come nextNext Steps after this PR merges
NOTE: None of this is being done as part of this PR. This PR creates an entirely new example folder called
complete
complete-managed-nodegroup
examplecomplete-self-managed-nodegroup
exampleBREAKING CHANGES WERE MADE TO THE BASTION MODULE
Changes were needed in order to add uniqueness to resource names which is important when offering the ability to do automated testing.
name
from optional (with default value of""
) to requiredaccess_log_bucket_name
toaccess_log_bucket_name_prefix
bucket_name
tosession_log_bucket_name_prefix
count
field on several resources to account for variability in resource names (the way it is in main does not allow for any variability, it threw errorThe "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created.
)BREAKING CHANGES WERE MADE TO THE S3-IRSA MODULE
Changes were needed in order to add uniqueness to resource names which is important when offering the ability to do automated testing.
bucket_prefix
andcluster_name
and replace them with variablename_prefix
Closes #14