Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Automated testing #90

Merged
merged 97 commits into from
Mar 14, 2023
Merged

[BREAKING] Automated testing #90

merged 97 commits into from
Mar 14, 2023

Conversation

RothAndrew
Copy link
Member

@RothAndrew RothAndrew commented Mar 2, 2023

BLUF

  • Add new example called complete that is capable of running in either "insecure mode" or "secure mode" by switching which tfvars overlay is used. Insecure mode is ready as part of this PR, secure mode will come next
  • Make the documentation for deploying an example way easier by leveraging make, docker, and terratest
  • Add an automated test that tests the complete example in insecure mode

Next Steps after this PR merges

NOTE: None of this is being done as part of this PR. This PR creates an entirely new example folder called complete

  1. Delete the complete-managed-nodegroup example
  2. Add secure mode to the complete example
  3. Add an automated test for secure mode
  4. Delete the complete-self-managed-nodegroup example

BREAKING CHANGES WERE MADE TO THE BASTION MODULE

Changes were needed in order to add uniqueness to resource names which is important when offering the ability to do automated testing.

  • [Breaking] Change variable name from optional (with default value of "") to required
  • [Breaking] Rename variable access_log_bucket_name to access_log_bucket_name_prefix
  • [Breaking] Rename variable bucket_name to session_log_bucket_name_prefix
  • [Non-Breaking] Update the count field on several resources to account for variability in resource names (the way it is in main does not allow for any variability, it threw error The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created.)

BREAKING CHANGES WERE MADE TO THE S3-IRSA MODULE

Changes were needed in order to add uniqueness to resource names which is important when offering the ability to do automated testing.

  • [Breaking] Remove variables bucket_prefix and cluster_name and replace them with variable name_prefix

Closes #14

@RothAndrew RothAndrew requested a review from a team as a code owner March 13, 2023 17:53
@RothAndrew
Copy link
Member Author

/test all

@RothAndrew RothAndrew changed the title [WIP] [BREAKING] Automated testing [BREAKING] Automated testing Mar 13, 2023
@RothAndrew RothAndrew requested a review from zack-is-cool March 13, 2023 18:30
wirewc
wirewc previously approved these changes Mar 13, 2023
Copy link

@wirewc wirewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging until @RothAndrew decides too. Approved!

@RothAndrew
Copy link
Member Author

Waiting for at least 1 more person to review and approve, preferably @zack-is-cool. Zack, let me know when you get around to looking at this, I'd like to pair up with you and look at it together

@RothAndrew
Copy link
Member Author

/test all

@RothAndrew
Copy link
Member Author

/test all

@ntwkninja
Copy link
Member

@zack-is-cool LGTM

Copy link
Member

@zack-is-cool zack-is-cool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good to me. +1 for pairing session.

zack-is-cool
zack-is-cool previously approved these changes Mar 14, 2023
@RothAndrew
Copy link
Member Author

/test all

@RothAndrew
Copy link
Member Author

/test all

@RothAndrew RothAndrew merged commit 3d8a501 into main Mar 14, 2023
@RothAndrew RothAndrew deleted the feature/add-a-test branch March 14, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Testing pipeline for PRs
5 participants