Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose EFS toggle #109 #129

Merged
merged 34 commits into from
Apr 18, 2023
Merged

Expose EFS toggle #109 #129

merged 34 commits into from
Apr 18, 2023

Conversation

JaseKoonce
Copy link
Contributor

@JaseKoonce JaseKoonce commented Mar 30, 2023 •
edited
Loading

Adds EFS toggle for another storage option in addition to EBS. Currently setting the default for EFS_ENABLED to false.

@JaseKoonce
WIP/base efs configs
5d63184 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
tested/WIP
bac6612 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce JaseKoonce linked an issue Mar 30, 2023 that may be closed by this pull request
Expose EFS toggle #109
Closed
RothAndrew and others added 7 commits March 31, 2023 14:15
@RothAndrew @JaseKoonce
Add role-duration-seconds to aws creds step in workflow (#121)
1b79664
@zack-is-cool @JaseKoonce
fix race condition for destroying manifests and addons (#123)
57e594e 
* fix race condition for destroying manifests and addons
@ntwkninja @JaseKoonce
delete extra sg configs (#118)
ccead60
@brianrexrode @ntwkninja @JaseKoonce
disable dynamoDB for loki, add configs to S3 (#117)
89779d5 
* disable dynamoDB for loki, add configs to S3

* removed the count for enabling versioning

---------

Co-authored-by: Gabe <[email protected]>
@runyontr @ntwkninja @JaseKoonce
S3 output role arn (#126)
c295b0f 
* Output for IRSA Role ARN

Signed-off-by: Tom Runyon <[email protected]>

* refrence resource with count correctly

Signed-off-by: Tom Runyon <[email protected]>

* refrence resource with count correctly

Signed-off-by: Tom Runyon <[email protected]>

* precommit updates

---------

Signed-off-by: Tom Runyon <[email protected]>
Co-authored-by: Gabe <[email protected]>
Co-authored-by: Gabe Scarberry <[email protected]>
@JaseKoonce
WIP/base efs configs
0df575d 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
adding vpc endpoint/randomizing efs names
d5e61f4 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
Copy link
Contributor Author

/test all

zack-is-cool and others added 3 commits March 31, 2023 14:34
@zack-is-cool @JaseKoonce
fix race condition for destroying manifests and addons (#123)
e696860 
* fix race condition for destroying manifests and addons
@JaseKoonce
WIP/base efs configs
1495738 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
duplicate variables fix/rebase
87ef57a 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
double argument fix
3da97cc 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
test fix
a074fd4 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce JaseKoonce changed the title Expose EFS toggle #109/WIP Expose EFS toggle #109 Apr 3, 2023
@JaseKoonce JaseKoonce marked this pull request as ready for review April 3, 2023 14:20
@JaseKoonce JaseKoonce requested review from a team as code owners April 3, 2023 14:20
@JaseKoonce JaseKoonce marked this pull request as draft April 3, 2023 20:35
@JaseKoonce
pre-commit
19b848b 
Signed-off-by: jase koonce <[email protected]>
@JaseKoonce JaseKoonce marked this pull request as ready for review April 3, 2023 20:57
@wirewc
Copy link

wirewc commented Apr 4, 2023

/test all

ntwkninja
ntwkninja reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@ntwkninja ntwkninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommending minor changes and also we need to add a test (recommend a brief discussion on the latter)

modules/eks/main.tf Outdated Show resolved Hide resolved
@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
Copy link
Contributor Author

/test all

@JaseKoonce
Pre-commit
b471dc2 
Signed-off-by: jase koonce <[email protected]>
@ntwkninja
Copy link
Member

/test all

ntwkninja
ntwkninja approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@ntwkninja ntwkninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JaseKoonce JaseKoonce merged commit 4edafe7 into main Apr 18, 2023
@JaseKoonce JaseKoonce deleted the efs-toggle branch April 18, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew left review comments

@ntwkninja ntwkninja ntwkninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose EFS toggle
7 participants
@JaseKoonce @wirewc @ntwkninja @RothAndrew @zack-is-cool @brianrexrode @runyontr