Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete extra sg configs #118

Merged
merged 2 commits into from
Mar 29, 2023
Merged

delete extra sg configs #118

merged 2 commits into from
Mar 29, 2023

Conversation

ntwkninja
Copy link
Member

upstream EKS configures needed security groups. these were duplicates / left over from blueprints

@ntwkninja ntwkninja requested a review from a team as a code owner March 27, 2023 19:08
@ntwkninja
Copy link
Member Author

/test all

Copy link
Contributor

@JaseKoonce JaseKoonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntwkninja ntwkninja merged commit d9e0f76 into main Mar 29, 2023
@ntwkninja ntwkninja deleted the eks-sg-updates branch March 29, 2023 02:00
JaseKoonce pushed a commit that referenced this pull request Mar 31, 2023
JaseKoonce added a commit that referenced this pull request Apr 18, 2023
* WIP/base efs configs

Signed-off-by: jase koonce <[email protected]>

* tested/WIP

Signed-off-by: jase koonce <[email protected]>

* Add role-duration-seconds to aws creds step in workflow (#121)

* fix race condition for destroying manifests and addons (#123)

* fix race condition for destroying manifests and addons

* delete extra sg configs (#118)

* disable dynamoDB for loki, add configs to S3 (#117)

* disable dynamoDB for loki, add configs to S3

* removed the count for enabling versioning

---------

Co-authored-by: Gabe <[email protected]>

* S3 output role arn (#126)

* Output for IRSA Role ARN

Signed-off-by: Tom Runyon <[email protected]>

* refrence resource with count correctly

Signed-off-by: Tom Runyon <[email protected]>

* refrence resource with count correctly

Signed-off-by: Tom Runyon <[email protected]>

* precommit updates

---------

Signed-off-by: Tom Runyon <[email protected]>
Co-authored-by: Gabe <[email protected]>
Co-authored-by: Gabe Scarberry <[email protected]>

* WIP/base efs configs

Signed-off-by: jase koonce <[email protected]>

* adding vpc endpoint/randomizing efs names

Signed-off-by: jase koonce <[email protected]>

* fix race condition for destroying manifests and addons (#123)

* fix race condition for destroying manifests and addons

* WIP/base efs configs

Signed-off-by: jase koonce <[email protected]>

* duplicate variables fix/rebase

Signed-off-by: jase koonce <[email protected]>

* double argument fix

Signed-off-by: jase koonce <[email protected]>

* test fix

Signed-off-by: jase koonce <[email protected]>

* Add Provider Plugin Cache to automated testing (#130)

* Update eks-addons.tf to fix Ondat issue (#131)

* WIP/base efs configs

Signed-off-by: jase koonce <[email protected]>

* rebase for Ondat fix

Signed-off-by: jase koonce <[email protected]>

* rebase for Ondat fix

Signed-off-by: jase koonce <[email protected]>

* pre-commit

Signed-off-by: jase koonce <[email protected]>

* security group adjustment/tested

Signed-off-by: jase koonce <[email protected]>

* adding reclaim policy variable to efs storage class

Signed-off-by: jase koonce <[email protected]>

* pre-commit

Signed-off-by: jase koonce <[email protected]>

* Set enable efs to true in fixtures.common

Signed-off-by: jase koonce <[email protected]>

* Pre-commit

Signed-off-by: jase koonce <[email protected]>

---------

Signed-off-by: jase koonce <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: JaseKoonce <[email protected]>
Signed-off-by: Gabe <[email protected]>
Co-authored-by: Andy Roth <[email protected]>
Co-authored-by: Zack A <[email protected]>
Co-authored-by: Gabe <[email protected]>
Co-authored-by: brianrexrode <[email protected]>
Co-authored-by: Thomas Runyon <[email protected]>
Co-authored-by: Gabe Scarberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants