-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable dynamoDB for loki, add configs to S3 #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test all |
/test all |
ntwkninja
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
closes #111 |
JaseKoonce
pushed a commit
that referenced
this pull request
Mar 31, 2023
* disable dynamoDB for loki, add configs to S3 * removed the count for enabling versioning --------- Co-authored-by: Gabe <[email protected]>
JaseKoonce
added a commit
that referenced
this pull request
Apr 18, 2023
* WIP/base efs configs Signed-off-by: jase koonce <[email protected]> * tested/WIP Signed-off-by: jase koonce <[email protected]> * Add role-duration-seconds to aws creds step in workflow (#121) * fix race condition for destroying manifests and addons (#123) * fix race condition for destroying manifests and addons * delete extra sg configs (#118) * disable dynamoDB for loki, add configs to S3 (#117) * disable dynamoDB for loki, add configs to S3 * removed the count for enabling versioning --------- Co-authored-by: Gabe <[email protected]> * S3 output role arn (#126) * Output for IRSA Role ARN Signed-off-by: Tom Runyon <[email protected]> * refrence resource with count correctly Signed-off-by: Tom Runyon <[email protected]> * refrence resource with count correctly Signed-off-by: Tom Runyon <[email protected]> * precommit updates --------- Signed-off-by: Tom Runyon <[email protected]> Co-authored-by: Gabe <[email protected]> Co-authored-by: Gabe Scarberry <[email protected]> * WIP/base efs configs Signed-off-by: jase koonce <[email protected]> * adding vpc endpoint/randomizing efs names Signed-off-by: jase koonce <[email protected]> * fix race condition for destroying manifests and addons (#123) * fix race condition for destroying manifests and addons * WIP/base efs configs Signed-off-by: jase koonce <[email protected]> * duplicate variables fix/rebase Signed-off-by: jase koonce <[email protected]> * double argument fix Signed-off-by: jase koonce <[email protected]> * test fix Signed-off-by: jase koonce <[email protected]> * Add Provider Plugin Cache to automated testing (#130) * Update eks-addons.tf to fix Ondat issue (#131) * WIP/base efs configs Signed-off-by: jase koonce <[email protected]> * rebase for Ondat fix Signed-off-by: jase koonce <[email protected]> * rebase for Ondat fix Signed-off-by: jase koonce <[email protected]> * pre-commit Signed-off-by: jase koonce <[email protected]> * security group adjustment/tested Signed-off-by: jase koonce <[email protected]> * adding reclaim policy variable to efs storage class Signed-off-by: jase koonce <[email protected]> * pre-commit Signed-off-by: jase koonce <[email protected]> * Set enable efs to true in fixtures.common Signed-off-by: jase koonce <[email protected]> * Pre-commit Signed-off-by: jase koonce <[email protected]> --------- Signed-off-by: jase koonce <[email protected]> Signed-off-by: Tom Runyon <[email protected]> Signed-off-by: JaseKoonce <[email protected]> Signed-off-by: Gabe <[email protected]> Co-authored-by: Andy Roth <[email protected]> Co-authored-by: Zack A <[email protected]> Co-authored-by: Gabe <[email protected]> Co-authored-by: brianrexrode <[email protected]> Co-authored-by: Thomas Runyon <[email protected]> Co-authored-by: Gabe Scarberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled the use of dynamoDB for loki, using the embedded boltdb-shipper instead.
Added versioning, logging and policy to loki S3 bucket.
Hardcoded the loki service account to match what's deployed with the loki component in BigBang.
Removed SSM actions from policies since they are not needed.