Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Transactions views layout #3326

Merged
merged 15 commits into from
Apr 5, 2021
Merged

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Mar 21, 2021

Closes #3282.
Closes #3283.
Closes #3334.
Closes #3280.

This diff should be merged after #3278. After it, I will handle the merge conflicts around Layout.less.
Notes:

@bgptr bgptr changed the title [WIP] Updated receive view layout [WIP] Updated Transactions views layout Mar 21, 2021
@amass01
Copy link
Member

amass01 commented Mar 21, 2021

I skinned the account select input as it is in the design, but I did not replace it with a pi-ui component. I think it should be handled in a separate PR globally.

Good point mate, worth creating an issue, it would be great if we replace all input components with generic input
imported from pi-ui.

@bgptr
Copy link
Collaborator Author

bgptr commented Mar 22, 2021

@amassarwi I found that there is already an open issue about this. I linked it in the description.

@bgptr bgptr force-pushed the new-receive-view branch 2 times, most recently from 3038b64 to 555850b Compare March 24, 2021 15:51
@bgptr bgptr changed the title [WIP] Updated Transactions views layout Updated Transactions views layout Mar 24, 2021
@alexlyp
Copy link
Member

alexlyp commented Mar 26, 2021

Overall looks really good. Only thing that looks a little wacky is the "Paste" text in the button looks off to my eye. Like the text is too wide or something.

Copy link
Member

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM!

@bgptr
Copy link
Collaborator Author

bgptr commented Mar 26, 2021

Thank you guys for the review.
@alexlyp I used pi-ui Button component and I did not notice it uses Arial by default. Good catch, thx! I've fixed it.

#3336 broke the layout a little bit. I tried to hunt down every misalignment, but if a fresh eye could check this PR again, it would be great.

@amass01
Copy link
Member

amass01 commented Mar 26, 2021

Testing...

Copy link
Member

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!!

Hit the following warnings in console - the first one seems to happen on master as well:

image

@bgptr
Copy link
Collaborator Author

bgptr commented Mar 29, 2021

@amassarwi Thanks for the test. I fixed the warnings.

@alexlyp alexlyp merged commit 650752e into decred:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tabbed page header on smaller screens Export view update Receive view update Send view update
3 participants