-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Transactions
views layout
#3326
Conversation
Transactions
views layout
Good point mate, worth creating an issue, it would be great if we replace all input components with generic input |
@amassarwi I found that there is already an open issue about this. I linked it in the description. |
3038b64
to
555850b
Compare
Transactions
views layoutTransactions
views layout
Overall looks really good. Only thing that looks a little wacky is the "Paste" text in the button looks off to my eye. Like the text is too wide or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM!
Testing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amassarwi Thanks for the test. I fixed the warnings. |
Closes #3282.
Closes #3283.
Closes #3334.
Closes #3280.
This diff should be merged after #3278. After it, I will handle the merge conflicts aroundLayout.less
.Notes:
pi-ui
component. I think it should be handled in a separate PR globally. After this PR, we should take care of Change react-select dependency #2517.