Functional components/layout/* with css modules #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
force-pushed
the
funclayout
branch
2 times, most recently
from
d651b15
to
d45e893
Compare
amass01
changed the title
bgptr
reviewed
Mar 20, 2021
Merged
alexlyp
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting on #3215 as it conflicts withlayout.less.This refactors
components/layout/*components to functional approach and splitslayout.lessto many local, component specific, encapsulated css modules.It also adds few className props to custom style parts of
TabbedPage&TabbedPageTab, before this commit we used to override classes in too many differentlessfiles but with this approach wrapper will provide specific className defined in it's css module instead of overriding children css classes in wrapper's.lessfile.This also deletes couple of redux connectors &
MyTickets.lesswhich wasn't used anymore.Part of #2438 & #2439.