Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align decrediton's global box-sizing property with pi-ui. #3336

Merged
merged 4 commits into from
Mar 26, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Mar 25, 2021

This gets rid of a styling hack which was used to resolve a global styling conflict between pi-ui and
decrediton.

Before this commit:

/* TODO: delete box-sizing: content-box;
// I added this ugly `:not` workaround to be able to skip pi-ui's classes
// which are prefixed with 'styles_'.
// Ideally we should use `* { box-sizing: inherit; } and html { box-sizing: border-box }`(already done in pi-ui)
// we shouldn't override it in a global level - we should take care of this while migrating this file to a css module.*/
*:not([class^="styles_"]),
*:not([class^="styles_"])::before,
*:not([class^="styles_"])::after {
  box-sizing: content-box;
}

[class^="styles_"] > * {
  box-sizing: inherit;
}

As mentioned in the code comment above; before this diff decrediton's needed box-sizing: content-box; which conflicted with pi-ui's which defines * { box-sizing: inherit; } and html { box-sizing: border-box }.

After ditching box-sizing: content-box; I needed to tweak width/height property of many parts of decrediton.

@amass01 amass01 marked this pull request as draft March 25, 2021 15:53
@amass01 amass01 marked this pull request as ready for review March 26, 2021 00:14
@alexlyp
Copy link
Member

alexlyp commented Mar 26, 2021

Not sure if it was introduced in this PR, but seeing a misalignment in the Extended PubKey area in Account Details

@alexlyp
Copy link
Member

alexlyp commented Mar 26, 2021

Yah confirmed that it was introduced in this PR.

@amass01
Copy link
Member Author

amass01 commented Mar 26, 2021

@alexlyp good catch, updating it.

@amass01
Copy link
Member Author

amass01 commented Mar 26, 2021

@alexlyp updated 👍

Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@alexlyp alexlyp merged commit b7ebf9a into decred:master Mar 26, 2021
@amass01 amass01 deleted the csshack branch March 26, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants