multi: enable token trading #1622

buck54321 · 2022-05-19T14:49:23Z

client/asset:
Add allowable networks to RegisterToken. The client can then use
the new package function SetNetwork during initialization to filter out
incompatible tokens.

client/asset/eth:
Change OpenTokenWallet to use a single struct argument. Add PeersChange
function and notify token wallets of peer changes.
Fix bugs in swap fee estimation to deal with transfer approval.

client/core:
Plumb in token wallet creation and opening.
Add TokenInfo field to SupportedAsset, populated instead of the
Info field for token wallets. Should consider changing the name
of the Info field to better illustrate the purpose and to break
Go consumer's API to force adaptation to the new semantics.

client/webserver:
Add token to live tests.

ui:
Implement new wallet creation flow for token wallets that includes
a step to sync the parent. Adapt to new SupportedAsset structure.
Add "token-aware symbols", which are symbols that, for tokens, have
an additional <sup> element denoting the parent asset.

testing:
Loadbot and core simnet tests are updated for dextt.eth.

client/webserver/site/src/js/doc.ts

JoeGruffins

loadbot was working fine before, but now seeing 2022-06-27 16:09:45.067 [CRT] MANTLE:CMPD:STACKER:0: failed to send funds to alpha: invalid hex address "\"0x18d65fb8d60c1199bb1ad381be47aa692b482605\""

It seems getCodeAt is failing for the eth simnet tests.

I think that the core method assetHasActiveOrders now needs more logic if the asset is a asset.TokenMaster we need to also check active orders for all assets this is a parent wallet of.

Seems to be working very well.

One UI issue, <invalid coin>:

JoeGruffins · 2022-06-27T02:55:17Z

client/asset/driver.go

@@ -10,10 +10,17 @@ import (
 	"decred.org/dcrdex/dex"
 )

+// nettedToken is a Token with it's available networks. Saving the valid


it's -> its

JoeGruffins · 2022-06-27T04:15:13Z

client/asset/eth/nodeclient.go

+	p := n.leth.ApiBackend.SyncProgress()
+	if p.HighestBlock == 0 && p.CurrentBlock > 0 {
+		// If we shutdown and restart without going out of sync with peers,
+		// the HighestBlock will never be set.
+		// I guess just assume that if we have peers and HighestBlock is zero,
+		// that we're synced.
+		// TODO: Check for a race here. Can we pull a peer before we know its
+		// best block?
+		if n.p2pSrv.PeerCount() > 0 {
+			p.HighestBlock = p.CurrentBlock
+		}
+	}
+
+	return p


I think there's no need to change this now with #1630

Is it still broken?

JoeGruffins · 2022-06-27T04:54:36Z

client/core/core.go

+	// Start a goroutine to wait until the parent wallet is synced, and then
+	// begin creation of the token wallet.
+	c.wg.Add(1)
+	c.pendingCreateWallet.Store(&assetID)


It looks like we can only ever have one pending wallet at a time? Does this need logic for multiple create wallet attempts with different tokens? Because parent creation should be synchronous, it wouldn't make it here with only one parent assetID (eth). But if there were more?

It looks like if another asset were pending, it would just overwrite here.

If the same parent, the second token wallet would not wait for the parent to sync, although creation would be synchronous.

It also looks like if _, found := c.wallet(ID) could return not found for two calls close together, and create either the token or parent multiple times. I guess this was possible before though.

martonp · 2022-07-03T05:26:03Z

"Balances" is slipping out of the box.

martonp · 2022-07-03T08:31:11Z

This is probably a separate issue, but it doesn't make sense to show these reconfigure sections for wallets that have nothing to reconfigure.

martonp · 2022-07-03T09:17:12Z

client/webserver/site/src/js/wallets.ts

@@ -530,7 +534,7 @@ export default class WalletsPage extends BasePage {
    this.lastFormAsset = assetID
    const wallet = app().walletMap[assetID]
    if (!wallet) {
-      app().notify(ntfn.make('Cannot send/withdraw.', `No wallet found for ${asset.info.name}`, ntfn.ERROR))
+      app().notify(ntfn.make('Cannot send/withdraw.', `No wallet found for ${asset.name}`, ntfn.ERROR))


Below on line 558 - asset.info.unitinfo is causing an error. It would be better if the info and token fields were optional and the ts compiler forced you to check if it is defined.

martonp · 2022-07-03T09:25:28Z

client/asset/driver.go

+// SetNetwork will filter registered assets for those available on the specified
+// network. SetNetwork need only be called once during initialization.
+func SetNetwork(net dex.Network) {
+nextasset:


Why is this nextasset needed?

Because I want to continue here and not at the for _, allowedNet := range nt.nets { loop.

martonp · 2022-07-03T09:36:44Z

client/asset/eth/eth.go

@@ -621,8 +622,8 @@ func (w *assetWallet) lockFunds(amt uint64, t fundReserveType) error {
 	}

 	if balance.Available < amt {
-		return fmt.Errorf("attempting to lock more for %s than is currently available. %d > %d",
-			t, amt, balance.Available)
+		return fmt.Errorf("attempting to lock more %s for %s than is currently available. %d > %d",


This is a preexisting issue, but since these error messages show up on the UI, they should use the proper units.

martonp · 2022-07-03T12:47:54Z

client/core/core.go

-			}
-		},
-		DataDir: c.assetDataDirectory(assetID),
+	token := asset.TokenInfo(assetID)


NBD, but I would put this right before the if token == nil check.

martonp · 2022-07-03T13:15:35Z

client/webserver/locales/en-us.go

@@ -238,4 +239,6 @@ var EnUS = map[string]string{
 	"successful_cert_update":      "Successfully updated certificate!",
 	"update dex host":             "Update DEX Host",
 	"copied":                      "Copied!",
+	"Synchronizing":               "Synchronizing",
+	"wallet_wait_synced":          "wallet will be created after sync",


wallet will be created after parent wallet syncs?

Meh. It says "Syncing Ethereum" right above this message.

martonp · 2022-07-03T13:32:56Z

client/webserver/site/src/js/forms.ts

@@ -76,6 +121,22 @@ export class NewWalletForm {
    else Doc.show(...this.pwHiders)
  }

+  async createWallet (assetID: number, walletType: string, pw: string, parentForm?: WalletConfig | null) {


Do you need the | null? Isn't the ? enough?

martonp · 2022-07-07T12:10:44Z

client/core/core.go

+				Token:                 token,
+				Name:                  token.Name,
+				UnitInfo:              token.UnitInfo,
+				WalletCreationPending: tokenID == creatingWalletID,


If two token wallets are being created concurrently the one that started first would have this set to false.

Was resolved in 9ebb3da, I think.

JoeGruffins

See this often in logs:

2022-07-19 14:31:08.166 [ERR] CORE[eth][DEXTT.ETH]: (60000) error estimating swap gas: gas required exceeds allowance (11673760)
2022-07-19 14:31:08.166 [ERR] WEB: max order estimation error: dextt.eth wallet MaxOrder error: error getting swap gas estimate: gas required exceeds allowance (11673760)

And this once:

2022-07-19 14:24:49.438 [ERR] CORE: retiring order 9ac2316cdb9559eafd9d4c3c63ef87c815a6b45b1a745e2409733e51929c0080 with 100000000 > 0 refund funds locked

But looks good to me!

dex/networks/eth/tokens.go

chappjc · 2022-07-20T19:55:41Z

server/cmd/dcrdex/importlgpl.go

 	_ "decred.org/dcrdex/server/asset/eth" // register eth asset
 )
+
+func init() {
+	dexeth.MaybeReadSimnetAddrs()


Doesn't feel good to be doing this with production/mainnet code, but MaybeReadSimnetAddrs clearly only touches the dex.Simnet map entries so I guess it's alright.

I feel similarly. Better solution desired.

chappjc · 2022-07-20T19:58:56Z

server/asset/eth/coiner.go

+		for _, in := range inits {
+			sum += in.Value
+		}
+		if bc.value < sum {


For a token where bc.value is ETH and inits[i].Value is the token unit this check doesn't work so you skip it, but is it OK to just let the inits have any values? Would there ideally be balance check on the from account's token x balance? Does that get caught somewhere else or just failed swap (and penalization)?

Should be filtered by the if eth.assetID == BipID { above. Should probably rename the receiver for AssetBackend.

Right, that's what I mean by "this check doesn't work so you skip it". Still uncertain if an analogous check in the proper units is needed or happens somewhere else already.

This sent me down a rabbit-hole actually. We were still using gwei in the dexeth.Initiation struct, which was shared between tokens and eth, so needed consideration of the contract's decimals. Switched it to a *big.Int in evm units, and that echoed through a few places.

That would have been an issue for e.g. usdc.

client/asset/driver.go

chappjc · 2022-07-20T20:12:11Z

client/core/core.go

@@ -1475,6 +1502,21 @@ func (c *Core) storeDepositAddress(wdbID []byte, addr string) error {

 func (c *Core) connectAndUpdateWallet(w *xcWallet) error {
 	assetID := w.AssetID
+
+	token := asset.TokenInfo(w.AssetID)


assetID is declared above, might as well use it here and a few places in this new code

Still using w.AssetID in two spots right below this.

client/core/core.go

buck54321 · 2022-07-21T11:27:55Z

See this often in logs:

2022-07-19 14:31:08.166 [ERR] CORE[eth][DEXTT.ETH]: (60000) error estimating swap gas: gas required exceeds allowance (11673760)
2022-07-19 14:31:08.166 [ERR] WEB: max order estimation error: dextt.eth wallet MaxOrder error: error getting swap gas estimate: gas required exceeds allowance (11673760)

Yeah, isn't that curious? That happens when running estimateGas. I've looked into it, but it's confusing. It seems like geth thinks we're hitting some kind of limit on the total gas spent in a block or something. I'm almost certain it's a simnet thing, but we should figure it out.

I actually thought this was happening sometimes for ETH too, but maybe I was mistaken. Will test more.

buck54321 · 2022-07-21T12:53:11Z

I'm still looking into insufficient balance errors for the fee asset = eth from server in loadbot.

chappjc · 2022-07-22T18:43:25Z

Heaps of conflicts with #1600 merged, but I squashed and rebased locally without trouble, so looks mostly trivial. A bunch of ~~.info~~ for the most part.

martonp

Working well, I was unable to make anything go wrong. Just need to fix that balances text on the market page.

martonp · 2022-08-08T06:12:24Z

client/asset/eth/eth.go

 	// Test token
-	registerToken(testTokenID, "A token wallet for the DEX test token. Used for testing DEX software.")
+	registerToken(testTokenID, "A token wallet for the DEX test token. Used for testing DEX software.", dex.Simnet)


Instead of hardcoding dex.Simnet over here, you could check which networks are defined in the Tokens map in dex/networks/eth/token.go. nbd though.

Unfortunately not, because we won't have called MaybeReadSimnetAddrs yet. I'm open to other solutions though.

martonp · 2022-08-08T06:14:20Z

client/asset/eth/eth.go

@@ -645,8 +646,8 @@ func (w *assetWallet) lockFunds(amt uint64, t fundReserveType) error {
 	}

 	if balance.Available < amt {
-		return fmt.Errorf("attempting to lock more for %s than is currently available. %d > %d",
-			t, amt, balance.Available)
+		return fmt.Errorf("attempting to lock more %s for %s than is currently available. %d > %d gwei",


It won't be gwei if it's a token.

This is an issue in many other places as well, the error messages are a little confusing when they show up on the UI. I can do another PR for this after this one goes in.

martonp · 2022-08-08T06:35:19Z

client/core/core.go

-		if err != nil {
-			return err
-		}
+	if err = c.setWalletCreationPending(assetID); err != nil {


Would it cause an issue if someone quickly clicks to create two separate token wallets, and it will simultaneously start creating the parent ETH wallet twice?

martonp · 2022-08-08T06:40:13Z

client/core/core.go

+	// Create the parent synchronously.
+	parentWallet, err := c.createWalletOrToken(crypter, walletPW, form.ParentForm)
+	if err != nil {
+		c.setWalletCreationComplete(assetID)


This could be a defer after you call setWalletCreationPending . It's good now, but might be easy to forget if someone puts some additional code here for some reason.

martonp · 2022-08-08T07:12:55Z

client/webserver/site/src/css/main.scss

@@ -467,3 +467,9 @@ div.border1 {
 .preline {
  white-space: pre-line;
 }
+


In market.scss there in the .market-bal-lbl section, there is a top: -11px which is causing the Balances: text to leave the box. I see it on both firefox and chrome. Maybe this was needed before, but now it's not.

Was on purpose, but needs updating. I'll be doing some work ont the markets page style soon.

chappjc · 2022-08-08T21:14:48Z

In client/core/trade.go, we should use the Receipt's stringer:

diff --git a/client/core/trade.go b/client/core/trade.go
index df0352f0..fbb86ffc 100644
--- a/client/core/trade.go
+++ b/client/core/trade.go
@@ -2074,7 +2074,7 @@ func (c *Core) swapMatchGroup(t *trackedTrade, matches []*matchTracker, errs *er
                match := matches[i]
                coin := receipt.Coin()
                c.log.Infof("Contract coin %v (%s), value = %d, refundable at %v (script = %v), match = %v",
-                       coin, t.wallets.fromAsset.Symbol, coin.Value(), receipt.Expiration(), receipt.Contract(), match)
+                       coin, t.wallets.fromAsset.Symbol, coin.Value(), receipt.Expiration(), receipt.String(), match)
                if secret := match.MetaData.Proof.Secret; len(secret) > 0 {
                        c.log.Tracef("Contract coin %v secret = %x", coin, secret)
                }

With .Contract() it's the undecoded "contract data" bytes:

2022-08-08 15:54:45.014 [INF] CORE: Contract coin 0x1c1009fea9a1c04f44c7dc6d4bf8db9ce1c2f6d727d836817e7ed1f45449fb6c (dextt.eth), value = 666600000, refundable at 2022-08-08 16:00:45 -0500 CDT (script = 000000000290c8950d9094f0c881ba16850d2c50bb6487c83e6d4336f0f530a995a4e75a), match = 58d2ca2823638d87d85163df46795b91ac759c0c0aedc79ff090b668d9d2b503

It's also not a "script", but that's just a holdover from utxo script obviously.

With the Stringer, it'll give something meaningful even if it's redundant with the Broadcasted transaction with X swap contracts for order log just prior:

2022-08-08 16:12:30.016 [INF] CORE: Contract coin 0xed2267dfb8e4b79fb518bcd47c15ce691fff3e849246347a764e4dca11474fc9 (dextt.eth), value = 46000000000, refundable at 2022-08-08 16:18:30 -0500 CDT (script = { tx hash: ed2267dfb8e4b79fb518bcd47c15ce691fff3e849246347a764e4dca11474fc9, contract address: 0x6b4368d3E41a60e20FF8539C843B3CDB38C8A507, secret hash: 9efdf6fc87bfdf41c91cffc1115076c4017538f075026c0beddb6ae2aa7f884f }), match = a83b886d29adc0f200cf40271a7b722c88b19f235011227418aaed5d5b3554dc

Maybe also we change contract = to data = or contract data =?

chappjc · 2022-08-08T22:08:38Z

See this often in logs:
2022-07-19 14:31:08.166 [ERR] CORE[eth][DEXTT.ETH]: (60000) error estimating swap gas: gas required exceeds allowance (11673760)
2022-07-19 14:31:08.166 [ERR] WEB: max order estimation error: dextt.eth wallet MaxOrder error: error getting swap gas estimate: gas required exceeds allowance (11673760)
Yeah, isn't that curious? That happens when running estimateGas. I've looked into it, but it's confusing. It seems like geth thinks we're hitting some kind of limit on the total gas spent in a block or something. I'm almost certain it's a simnet thing, but we should figure it out.

I actually thought this was happening sometimes for ETH too, but maybe I was mistaken. Will test more.

On mainnet, block gas limit has been increasing and is currently ~30 million in the post-london era, and geth says that --dev.gaslimit is default of 11.5 million as the starting gas limit, so if this estimate gas call wants more than 11.9 million, a huge portion of a real block's gas limit. That suggest to me it's for a crazy large number of lots making an unrealistically gas hungry txn.

This seems to be supported by the message if you don't have a lot of fee asset (try an exchange rate like 0.02 dextt/dcr):

2022-08-08 16:57:27.108 [DBG] CORE[eth][DEXTT.ETH]: Skipping live swap gas because contract is not approved for transferFrom
2022-08-08 16:57:27.108 [INF] CORE[eth][DEXTT.ETH]: MaxOrder reducing lots because of low fee reserves: 16666 -> 1379
2022-08-08 16:57:27.108 [DBG] CORE[eth][DEXTT.ETH]: Skipping live swap gas because contract is not approved for transferFrom

But I must be confused because the following gasses indicate we'd use and entire mainnet block with about a swap tx with ~265 inits in the batch. Even 10 lots, which is reasonable, would mean ~%4 of an entire block's gas limit? Can that be right?

var v0Gases = &Gases{
	Swap:      135000,
	SwapAdd:   113000,
	Redeem:    63000,
	RedeemAdd: 32000,
	Refund:    43000,
}

debugging:

diff --git a/client/asset/eth/eth.go b/client/asset/eth/eth.go
index f853fb38..eb1fc0e4 100644
--- a/client/asset/eth/eth.go
+++ b/client/asset/eth/eth.go
@@ -1047,6 +1047,8 @@ func (w *assetWallet) swapGas(n int, dexCfg *dex.Asset) (oneSwap, nSwap uint64,
                return oneSwap, nSwap, false, nil
        }
 
+       w.log.Infof("swapgas: %d / %v", n, nSwap)
+
        // If we've approved the contract to transfer, we can get a live
        // estimate to double check.

[INF] CORE[eth][DEXTT.ETH]: swapgas: 402 / 46289000

chappjc

Only some minor comments. All working well and code looks good.

The approval might eventually warrant a button in the wallets page because (a) it's not clear why live gas estimates don't work before approval until you look at the log, and (b) it's a bit dicey submitting a taker order before the approval tx is mined.

client/asset/driver.go

client/webserver/http.go

buck54321 · 2022-08-09T11:49:29Z

But I must be confused because the following gasses indicate we'd use and entire mainnet block with about a swap tx with ~265 inits in the batch. Even 10 lots, which is reasonable, would mean ~%4 of an entire block's gas limit? Can that be right?

I does seem limited, but considering that a regular tx is 21,000 gas, I think it's correct.

Just a reminder about #1426 too

var v0Gases = &dex.Gases{
	Swap:      135_000,
	SwapAdd:   113_000,
	Redeem:    63_000,
	RedeemAdd: 32_000,
	Refund:    43_000,
}

var v1Gases = &dex.Gases{
	Swap:      50_000,
	SwapAdd:   27_000,
	Redeem:    42_000,
	RedeemAdd: 14_000,
	// Refund: TODO,
}

chappjc · 2022-08-09T13:50:58Z

server/asset/eth/coiner.go

 			return nil, fmt.Errorf("tx %s value < sum of inits. %d < %d", bc.txHash, bc.value, sum)
 		}
 	}

 	return &swapCoin{
 		baseCoin: bc,
 		init:     init,
+		evmVal:   evmVal,


Is this meant to be used and/or set to something other than 0?

Whoops. Leftovers from intermediate iteration.

chappjc · 2022-08-09T14:01:57Z

I does seem limited, but considering that a regular tx is 21,000 gas, I think it's correct.

Back to the gas estimate issue, I think this means we should place a cap on the number of inits.

More broadly, it sounds like we need to place a cap on the number of lots otherwise there will be potentially unswappable orders, however huge they'd be.

chappjc · 2022-08-09T23:09:35Z

@martonp Pls circle back and we can merge.

chappjc · 2022-08-11T00:44:52Z

Oh, was ready to merge, but there are stupid cache buster conflicts. If you can't get to that tonight I'll take care of it.

client/asset: Add allowable networks to RegisterToken. The client can then use the new package function SetNetwork during initialization to filter out incompatible tokens. client/asset/eth: Change OpenTokenWallet to use a single struct argument. Add PeerChange function and notify token wallets of peer changes. Fix bugs in swap fee estimation to deal with transfer approval. client/core: Plumb in token wallet creation and opening. Add TokenInfo field to SupportedAsset, populated instead of the Info field for token wallets. Should consider changing the name of the Info field to better illustrate the purpose and to break Go consumer's API to force adaptation to the new semantics. client/webserver: Add token to live tests. ui: Implement new wallet creation flow for token wallets that includes a step to sync the parent. Adapt to new SupportedAsset structure. Add "token-aware symbols", which are symbols that, for tokens, have an additional <sup> element denoting the parent asset. testing: Loadbot and core simnet tests are updated for dextt.eth.

Fix remaining gwei unit in shared dexeth.Initiation struct. Fix busted nodeclient_harness_test.go tests. Prevent double parent wallet creation.

chappjc reviewed May 19, 2022

View reviewed changes

client/webserver/site/src/js/doc.ts Show resolved Hide resolved

chappjc added this to the TBD milestone May 25, 2022

This was referenced May 25, 2022

server/db/driver/pg: increase size of asset ID column in markets table #1621

Merged

eth: Sometimes sync progress HighestBlock cannot be trusted. #1628

Closed

buck54321 mentioned this pull request Jun 10, 2022

utility for running core harness tests #1632

Merged

buck54321 force-pushed the token-frontend branch 4 times, most recently from bd342a6 to 61c69fd Compare June 14, 2022 22:49

buck54321 force-pushed the token-frontend branch 4 times, most recently from e52f919 to d446ada Compare June 22, 2022 18:48

buck54321 marked this pull request as ready for review June 22, 2022 18:58

buck54321 force-pushed the token-frontend branch from d446ada to 5017279 Compare June 22, 2022 19:09

buck54321 mentioned this pull request Jun 24, 2022

app: refactor frontend notification flow #1685

Merged

buck54321 force-pushed the token-frontend branch from 5017279 to f5aa89d Compare June 25, 2022 12:36

JoeGruffins reviewed Jun 27, 2022

View reviewed changes

martonp reviewed Jul 7, 2022

View reviewed changes

buck54321 force-pushed the token-frontend branch from 9ebb3da to bc17947 Compare July 11, 2022 22:38

chappjc mentioned this pull request Jul 16, 2022

client/core: Popuplate AssetConfig on PreRedeem call #1713

Merged

buck54321 force-pushed the token-frontend branch from bc17947 to 0e0280d Compare July 18, 2022 11:36

JoeGruffins approved these changes Jul 19, 2022

View reviewed changes

chappjc reviewed Jul 20, 2022

View reviewed changes

buck54321 force-pushed the token-frontend branch from 0e0280d to c5b40ba Compare July 21, 2022 12:52

JoeGruffins mentioned this pull request Jul 22, 2022

erc20: Add USDC testnet support. #1724

Closed

JoeGruffins mentioned this pull request Jul 26, 2022

erc20: Add testnet usdc. #1733

Merged

buck54321 force-pushed the token-frontend branch from c5b40ba to 767cde3 Compare July 28, 2022 00:04

chappjc self-requested a review July 31, 2022 18:36

chappjc modified the milestones: TBD, 0.6/1.0 Aug 1, 2022

buck54321 force-pushed the token-frontend branch from 8e818d9 to 45d90d1 Compare August 5, 2022 00:11

martonp reviewed Aug 8, 2022

View reviewed changes

chappjc approved these changes Aug 8, 2022

View reviewed changes

client/asset/driver.go Show resolved Hide resolved

client/webserver/http.go Outdated Show resolved Hide resolved

buck54321 force-pushed the token-frontend branch from 45d90d1 to bb71ae0 Compare August 9, 2022 12:38

chappjc reviewed Aug 9, 2022

View reviewed changes

buck54321 mentioned this pull request Aug 9, 2022

eth: handle block size max #1771

Closed

chappjc requested a review from martonp August 9, 2022 23:09

martonp approved these changes Aug 11, 2022

View reviewed changes

buck54321 added 6 commits August 10, 2022 20:04

permit zero-balance for redemption-only in early return

266fa8d

return transaction hashes from send functions

1240b37

review followup

2853d01

Fix remaining gwei unit in shared dexeth.Initiation struct. Fix busted nodeclient_harness_test.go tests. Prevent double parent wallet creation.

update parent asset balances on order placement

10f0e02

cleanup

fe58aca

buck54321 force-pushed the token-frontend branch from a4c30bb to fe58aca Compare August 11, 2022 01:06

chappjc merged commit 74907fb into decred:master Aug 11, 2022

chappjc added the ETH label Mar 30, 2023

multi: enable token trading #1622

multi: enable token trading #1622

Conversation

buck54321 commented May 19, 2022 • edited Loading

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martonp commented Jul 3, 2022

martonp commented Jul 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc Jul 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 commented Jul 21, 2022 • edited Loading

buck54321 commented Jul 21, 2022

chappjc commented Jul 22, 2022

martonp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martonp Aug 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Aug 8, 2022 • edited Loading

chappjc commented Aug 8, 2022 • edited Loading

chappjc left a comment

Choose a reason for hiding this comment

buck54321 commented Aug 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Aug 9, 2022

chappjc commented Aug 9, 2022

chappjc commented Aug 11, 2022

buck54321 commented May 19, 2022 •

edited

Loading

chappjc Jul 20, 2022 •

edited

Loading

buck54321 commented Jul 21, 2022 •

edited

Loading

martonp Aug 8, 2022 •

edited

Loading

chappjc commented Aug 8, 2022 •

edited

Loading

chappjc commented Aug 8, 2022 •

edited

Loading